You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2013/11/26 00:18:59 UTC

git commit: Improve comments about data-page-initialized and data-ajax-active

Updated Branches:
  refs/heads/master 0ef56e79b -> 93168cd8d


Improve comments about data-page-initialized and data-ajax-active


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/93168cd8
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/93168cd8
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/93168cd8

Branch: refs/heads/master
Commit: 93168cd8d836fbfeadf52ed27b7e9fb28832c4ce
Parents: 0ef56e7
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Nov 25 15:18:44 2013 -0800
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Nov 25 15:18:44 2013 -0800

----------------------------------------------------------------------
 .../main/coffeescript/META-INF/modules/t5/core/pageinit.coffee    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/93168cd8/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
index b72e788..ca3f055 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
@@ -122,7 +122,8 @@ define ["underscore", "./console", "./dom", "./events"],
             # At this point, all libraries have been loaded, and all inits should have executed. Unless some of
             # the inits triggered Ajax updates (such as a core/ProgressiveDisplay component), then the page should
             # be ready to go. We set a flag, mostly used by test suites, to ensure that all is ready.
-            # Note that later Ajax requests do not change this attribute, so their timing continues to be tricky.
+            # Later Ajax requests will cause the data-ajax-active attribute to switch between "true" and "false",
+            # so some test logic may need to be driven by that instead.
 
             dom.body.attr "data-page-initialized", "true"