You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Zhangg7723 (via GitHub)" <gi...@apache.org> on 2023/03/09 06:56:46 UTC
[GitHub] [iceberg] Zhangg7723 opened a new issue, #7052: Default table location may cause table to be lost
Zhangg7723 opened a new issue, #7052:
URL: https://github.com/apache/iceberg/issues/7052
### Apache Iceberg version
1.1.0 (latest release)
### Query engine
Flink
### Please describe the bug 🐞
After these steps:
1. create table A.
2. rename table A to table B.
3. create table A.
4. drop table B.
table A location will be removed, because table A and B are stored in the same location.
In my opinion, table location should be unique with uuid suffix when table is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on issue #7052: 🐞Default table location may cause table to be lost
Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on issue #7052:
URL: https://github.com/apache/iceberg/issues/7052#issuecomment-1479745229
This is unfortunately very very difficult. Renaming a table would require moving all the associated files which is potentitally a very very large move, there are also currently no rules about an iceberg table having to have its files at the table location. We actually have many properties for doing just the opposite.
That said I think we have several options of dealing with this,
See chat here
https://apache-iceberg.slack.com/archives/C025PH0G1D4/p1679336480004559
And Issue here
https://github.com/apache/iceberg/issues/6890
and here
https://github.com/apache/iceberg/issues/4159
I think what we need to think about here is adding some additional safeguards on Remove Orphan files. For example we should check whether any known table locations in the catalogs could potentially conflict with our current table location (either matching or being a subdirectory)
Drop Table is basically safe since it only deletes known files, although some engines (Like Trino) also drop the root directory which is a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] 🐞Default table location may cause table to be lost [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #7052: 🐞Default table location may cause table to be lost
URL: https://github.com/apache/iceberg/issues/7052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] luoyuxia commented on issue #7052: 🐞Default table location may cause table to be lost
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on issue #7052:
URL: https://github.com/apache/iceberg/issues/7052#issuecomment-1479218489
Seems reasonable. Hive will also change the location of A when rename to B.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] github-actions[bot] commented on issue #7052: 🐞Default table location may cause table to be lost
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7052:
URL: https://github.com/apache/iceberg/issues/7052#issuecomment-1724647564
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] 🐞Default table location may cause table to be lost [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7052:
URL: https://github.com/apache/iceberg/issues/7052#issuecomment-1863642452
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org