You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/04/13 19:51:45 UTC
[GitHub] [parquet-mr] Fokko opened a new pull request, #1056: PARQUET-2274: Remove Yetus
Fokko opened a new pull request, #1056:
URL: https://github.com/apache/parquet-mr/pull/1056
I don't think this is used anywhere anymore.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PARQUET-2274: Remove Yetus [parquet-mr]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056#issuecomment-1767480920
@sekikn Do you have any comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PARQUET-2274: Remove Yetus [parquet-mr]
Posted by "sekikn (via GitHub)" <gi...@apache.org>.
sekikn commented on PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056#issuecomment-1767514705
No, I agree with replacing audience annotations with appropriate comments for now, since we don't have a tool for enforcing restriction based on the annotations, as mentioned by @gszadovszky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #1056: PARQUET-2274: Remove Yetus
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056#issuecomment-1513367871
We started to use this to mark somehow the public classes/methods that did not ment to be public for the API users but only because of our current module layout. Since we are on java8 we do not have anything else to mark them. But because we do not have any tools running on the API (not even talking about the client side) it does not really make sense to have these annotations. Maybe it would worth some comments as replacements of the annotations but I am not sure they would be checked before used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PARQUET-2274: Remove Yetus [parquet-mr]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056#issuecomment-1767009722
@shangxinli Sorry for the long wait, I've added the comments 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PARQUET-2274: Remove Yetus [parquet-mr]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056#issuecomment-1801331950
Thank you @sekikn for confirming. I'll move this forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PARQUET-2274: Remove Yetus [parquet-mr]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #1056: PARQUET-2274: Remove Yetus
Posted by "shangxinli (via GitHub)" <gi...@apache.org>.
shangxinli commented on PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056#issuecomment-1646864865
@Fokko Do you think you can add some comment and we merge this PR in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #1056: PARQUET-2274: Remove Yetus
Posted by "shangxinli (via GitHub)" <gi...@apache.org>.
shangxinli commented on PR #1056:
URL: https://github.com/apache/parquet-mr/pull/1056#issuecomment-1559479395
Yeah, adding some comments could help although sometimes people ignore it. But some of them are already used by other tool like the columnIndex one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org