[jira] [Commented] (AURORA-1581) Consider removing unused client updater RPCs

["Bill Farner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225510#comment-15225510 ] 

Bill Farner commented on AURORA-1581:
-------------------------------------

https://reviews.apache.org/r/45718/

> Consider removing unused client updater RPCs
> --------------------------------------------
>
>                 Key: AURORA-1581
>                 URL: https://issues.apache.org/jira/browse/AURORA-1581
>             Project: Aurora
>          Issue Type: Task
>          Components: Scheduler
>            Reporter: Maxim Khutornenko
>            Assignee: Bill Farner
>
> We have a few thrift RPCs left after client updater removal that are no longer in use. Consider deprecating and removing these to avoid bit rot:
> {noformat}
> Response acquireLock(1: LockKey lockKey)
> Response releaseLock(1: Lock lock, 2: LockValidation validation)
> Response getLocks()
> {noformat}
> In addition, {{Lock}} object should be dropped from the following RPCs:
> {noformat}
> Response createJob(1: JobConfiguration description, 3: Lock lock)
> Response scheduleCronJob(1: JobConfiguration description, 3: Lock lock)
> Response descheduleCronJob(4: JobKey job, 3: Lock lock)
> Response restartShards(5: JobKey job, 3: set<i32> shardIds, 6: Lock lock)
> Response addInstances(1: AddInstancesConfig config, 2: Lock lock)
> Response killTasks(1: TaskQuery query, 3: Lock lock)
> Response replaceCronTemplate(1: JobConfiguration config, 2: Lock lock)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)