You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/12 16:25:51 UTC
[PR] fix(web): refresh instance mutations with the latest list filters [rocketmq-dashboard]
btlqql opened a new pull request, #2026:
URL: https://github.com/apache/rocketmq-dashboard/pull/2026
## What is the purpose of the change
Fix #1996.
The Studio instance page captured loadInstances when a create, update, or delete mutation started. That callback also captured the search and instance-type filters from the same render. If an operator changed the list filters while the mutation request was in flight, the mutation completion invoked the stale callback whose refresh request used the old filters and overwrote the table with results that no longer matched the visible filters.
## Brief changelog
- instance page: mutations now bump a reloadVersion that triggers the list effect to re-run with the latest filters instead of calling a stale loadInstances closure
## How was this patch verified
- npx vitest run src/pages/instance/__tests__/InstancePage.test.tsx (11 passed)
- npx tsc -b clean
- npx eslint . clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): refresh instance mutations with the latest list filters [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2026: fix(web): refresh instance mutations with the latest list filters
URL: https://github.com/apache/rocketmq-dashboard/pull/2026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): refresh instance mutations with the latest list filters [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2026:
URL: https://github.com/apache/rocketmq-dashboard/pull/2026#issuecomment-5291346014
Closing per contribution guideline #2107: these are fragmented one-off changes of the same theme (one PR per guard/fix/page). Please group related changes into cohesive pull requests and resubmit — your contributions are welcome in a consolidated shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org