[GitHub] [ignite-python-thin-client] ivandasch commented on a change in pull request #4: IGNITE-14058: Bool arrays now return as bool array, not int array

[GitBox <gi...@apache.org>]

ivandasch commented on a change in pull request #4:
URL: https://github.com/apache/ignite-python-thin-client/pull/4#discussion_r564338563



##########
File path: pyignite/datatypes/primitive_arrays.py
##########
@@ -297,3 +297,10 @@ class BoolArrayObject(PrimitiveArrayObject):
     _type_id = TYPE_BOOLEAN_ARR
     primitive_type = Bool
     type_code = TC_BOOL_ARRAY
+
+    @classmethod
+    def to_python(cls, ctype_object, *args, **kwargs):
+        result = []

Review comment:
       ```
   if not ctype_object:
        return None
   result = False * ctype_object.length
   for i in range(ctype_objet.length):
        result[i] = ctype_object.data[i] != 0
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org