[GitHub] sdedic commented on a change in pull request #847: [NETBEANS-1147] Adapted fix for enabling host modules from jtulach:InstallNbJavacByEr…

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #847: [NETBEANS-1147] Adapted fix for enabling host modules from jtulach:InstallNbJavacByEr…
URL: https://github.com/apache/incubator-netbeans/pull/847#discussion_r215856088
 
 

 ##########
 File path: platform/autoupdate.services/src/org/netbeans/modules/autoupdate/updateprovider/AutoupdateCatalogParser.java
 ##########
 @@ -545,7 +545,11 @@ public void appendModuleAttributes (Attributes module) {
             String autoload = module.getValue (MODULE_ATTR_AUTOLOAD);
             String preferred = module.getValue(MODULE_ATTR_IS_PREFERRED_UPDATE);
                         
-            needsRestart = isFragment || needsrestart == null || needsrestart.trim ().length () == 0 ? null : Boolean.valueOf (needsrestart);
+            if (isFragment) {
+                needsRestart = true;
 
 Review comment:
   OK, let's take this change to #715. It just improves consistency with line ~570; I believe that  I added the isFragment condition erroneously here (parenthesis missing). Maybe better condition is needed: in fact restart is only needed if the hosting module is present/enabled prior to autoupdate operation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists