You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2018/10/25 16:49:00 UTC
[jira] [Comment Edited] (SOLR-12921) Separate Solr unit tests and
integration tests.
[ https://issues.apache.org/jira/browse/SOLR-12921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663990#comment-16663990 ]
Erick Erickson edited comment on SOLR-12921 at 10/25/18 4:48 PM:
-----------------------------------------------------------------
WDYT about changing precommit to forbid new files (and maybe changes too) in the current test file tree? The idea here is that if we want new work to respect the reorganization, adding that precommit check would freeze the current mixup and we could move tests into the new structure over time rather than all at once.
I have no idea how practical this is frankly, and it might mean some period of significant code duplication. If it can all be done in one big shot that'd be great. It's just that trying to do it all at once seems pretty hard.
A finer-grained approach would be to forbid specific directories under the tree, e.g.
...solr/core/src/test/org/apache/solr/analysis/
was (Author: erickerickson):
WDYT about changing precommit to forbid new files (and maybe changes too) in the current test file tree? The idea here is that if we want new work to respect the reorganization, adding that precommit check would freeze the current mixup and we could move tests into the new structure over time rather than all at once.
I have no idea how practical this is frankly, and it might mean some period of significant code duplication. If it can all be done in one big shot that'd be great. It's just that trying to do it all at once seems pretty hard.
> Separate Solr unit tests and integration tests.
> -----------------------------------------------
>
> Key: SOLR-12921
> URL: https://issues.apache.org/jira/browse/SOLR-12921
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mark Miller
> Priority: Major
>
> We basically just have "tests" now. We should have separate locations for unit and integration tests and new work should have a good reason to not include both.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org