You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Konrad Windszus <ko...@gmx.de> on 2021/02/26 08:56:26 UTC
[VOTE] Release Apache Jackrabbit Filevault 3.4.10
Hi,
A candidate for the Jackrabbit Filevault 3.4.10 release is available at:
https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.10/
The release notes can be found at https://issues.apache.org/jira/projects/JCRVLT/versions/12349480
The release candidate is a zip archive of the sources in:
https://github.com/apache/jackrabbit-filevault/tree/jackrabbit-filevault-3.4.10/
The SHA1 checksum of the archive is 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9.
The SHA512 checksum of the archive is 02791f91a7e2e62c192779349380a16d5f1d68ea4aa36ae273d609c885bfb55ca8a688e87d9510544505cd13b33e6099c3b26d7a9546f959ab05bd269ac50958
The command for running automated checks against this release candidate is:
$ sh check-release.sh filevault 3.4.10 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachejackrabbit-1539
Please vote on releasing this package as Apache Jackrabbit Filevault 3.4.10.
The vote is open for a minimum of 72 hours during business days and passes
if a majority of at least three +1 Jackrabbit PMC votes are cast.
The vote fails if not enough votes are cast after 1 week (5 business days).
[ ] +1 Release this package as Apache Jackrabbit Filevault 3.4.10
[ ] -1 Do not release this package because...
Konrad
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Konrad Windszus <ko...@gmx.de>.
Here is my +1
Konrad
> On 26. Feb 2021, at 09:56, Konrad Windszus <ko...@gmx.de> wrote:
>
> Hi,
> A candidate for the Jackrabbit Filevault 3.4.10 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.10/
>
> The release notes can be found at https://issues.apache.org/jira/projects/JCRVLT/versions/12349480
>
> The release candidate is a zip archive of the sources in:
>
> https://github.com/apache/jackrabbit-filevault/tree/jackrabbit-filevault-3.4.10/
>
> The SHA1 checksum of the archive is 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9.
> The SHA512 checksum of the archive is 02791f91a7e2e62c192779349380a16d5f1d68ea4aa36ae273d609c885bfb55ca8a688e87d9510544505cd13b33e6099c3b26d7a9546f959ab05bd269ac50958
>
> The command for running automated checks against this release candidate is:
> $ sh check-release.sh filevault 3.4.10 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachejackrabbit-1539
>
> Please vote on releasing this package as Apache Jackrabbit Filevault 3.4.10.
> The vote is open for a minimum of 72 hours during business days and passes
> if a majority of at least three +1 Jackrabbit PMC votes are cast.
> The vote fails if not enough votes are cast after 1 week (5 business days).
>
> [ ] +1 Release this package as Apache Jackrabbit Filevault 3.4.10
> [ ] -1 Do not release this package because...
>
> Konrad
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Konrad Windszus <ko...@gmx.de>.
AEM 6.3.0 ships with Jackrabbit 2.14.0!
This dependency is not embedded anywhere, and what matters (at least in OSGi containers) is what is deployed.
The Maven dependency must always be the oldest version you want to support...
Konrad
> On 26. Feb 2021, at 13:40, Julian Reschke <ju...@gmx.de> wrote:
>
> Am 26.02.2021 um 13:21 schrieb Konrad Windszus:
>> This is deliberate, as this is supposed to be backwards compatible : https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/RELEASE-NOTES.txt#L17
>>
>> Jackrabbit 2.14 and Oak 1.6 were the versions shipped with AEM 6.3 with which this release is supposed to be compatible. Check out the https://github.com/apache/jackrabbit-filevault/blob/master/target-osgi-environment/pom.xml
>> Konrad
>
> But then you'd still want the latest from 2.14, no?
>
> Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Julian Reschke <ju...@gmx.de>.
Am 26.02.2021 um 13:21 schrieb Konrad Windszus:
> This is deliberate, as this is supposed to be backwards compatible : https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/RELEASE-NOTES.txt#L17
>
> Jackrabbit 2.14 and Oak 1.6 were the versions shipped with AEM 6.3 with which this release is supposed to be compatible. Check out the https://github.com/apache/jackrabbit-filevault/blob/master/target-osgi-environment/pom.xml
> Konrad
But then you'd still want the latest from 2.14, no?
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Konrad Windszus <ko...@gmx.de>.
This is deliberate, as this is supposed to be backwards compatible : https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/RELEASE-NOTES.txt#L17
Jackrabbit 2.14 and Oak 1.6 were the versions shipped with AEM 6.3 with which this release is supposed to be compatible. Check out the https://github.com/apache/jackrabbit-filevault/blob/master/target-osgi-environment/pom.xml
Konrad
>
> I noticed that versions:display-dependency-updates shows a few 2.14.0
> references for Jackrabbit, and also ancient versions of
> jackson-databind. Not sure whether this is a problem in practice (you
> may want to check).
>
> Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Julian Reschke <ju...@gmx.de>.
Am 26.02.2021 um 12:14 schrieb Konrad Windszus:
>
>
>>
>> The simplest fix would be to remove the file from the ZIP, and then let
>> people retry...
>
> Not that easy, as then the checksums and the signature would no longer match...
> If you consider this a blocker I guess I have to respin the release...
> ...
Ack.
So with
--
Index: check-release.sh
===================================================================
--- check-release.sh (revision 46347)
+++ check-release.sh (working copy)
@@ -63,8 +63,8 @@
# https://github.blog/2011-10-20-improved-subversion-client-support/
TAGURL="https://github.com/apache/jackrabbit-filevault/tags/$COMPONENT-$VERSION"
MVN_ARGS=""
- CLEAN_SVN=".gitignore .gitattributes"
- CLEAN_ZIP=""
+ CLEAN_SVN=".gitignore .gitattributes derby.log"
+ CLEAN_ZIP="derby.log"
HASHES="sha1 sha512"
;;
*)
--
the build passes for me, where:
> [INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> [INFO] Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\usr\local\jdk18\jre
> [INFO] MAVEN_OPTS: -Xmx2g
I noticed that versions:display-dependency-updates shows a few 2.14.0
references for Jackrabbit, and also ancient versions of
jackson-databind. Not sure whether this is a problem in practice (you
may want to check).
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Konrad Windszus <ko...@gmx.de>.
>
> The simplest fix would be to remove the file from the ZIP, and then let
> people retry...
Not that easy, as then the checksums and the signature would no longer match...
If you consider this a blocker I guess I have to respin the release...
>
> Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Julian Reschke <ju...@gmx.de>.
Am 26.02.2021 um 11:51 schrieb Marcel Reutegger:
> Hi,
>
> On 26.02.21, 09:56, "Konrad Windszus" <ko...@gmx.de> wrote:
>> Please vote on releasing this package as Apache Jackrabbit Filevault
>> 3.4.10. The vote is open for a minimum of 72 hours during business days
>> and passes if a majority of at least three +1 Jackrabbit PMC votes are
>> cast. The vote fails if not enough votes are cast after 1 week (5
>> business days).
>
> The release check script failed with:
>
> [INFO] Comparing sources...
> [INFO]
> Only in ./target/jackrabbit-filevault-3.4.10/zip/jackrabbit-filevault-3.4.10/vault-core: derby.log
> [ERROR] NOT OK: Tagged sources are different from those in the archive
>
> I don't consider this a release blocker. Running tests on the source release
> manually was successful.
>
> +1 Release this package as Apache Jackrabbit Filevault 3.4.10
> ...
Interesting; over here, it didn't give me the details.
The simplest fix would be to remove the file from the ZIP, and then let
people retry...
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Konrad Windszus <ko...@gmx.de>.
Hi Marcel,
thanks for noticing. This is a slight regression of https://issues.apache.org/jira/browse/JCRVLT-505.
The file is generated by the Integration Tests in the wrong directory and therefore ended up in the source zip.
I created https://issues.apache.org/jira/browse/JCRVLT-508 for that.
Konrad
> On 26. Feb 2021, at 11:51, Marcel Reutegger <mr...@adobe.com> wrote:
>
> Hi,
>
> On 26.02.21, 09:56, "Konrad Windszus" <ko...@gmx.de> wrote:
>> Please vote on releasing this package as Apache Jackrabbit Filevault
>> 3.4.10. The vote is open for a minimum of 72 hours during business days
>> and passes if a majority of at least three +1 Jackrabbit PMC votes are
>> cast. The vote fails if not enough votes are cast after 1 week (5
>> business days).
>
> The release check script failed with:
>
> [INFO] Comparing sources...
> [INFO]
> Only in ./target/jackrabbit-filevault-3.4.10/zip/jackrabbit-filevault-3.4.10/vault-core: derby.log
> [ERROR] NOT OK: Tagged sources are different from those in the archive
>
> I don't consider this a release blocker. Running tests on the source release
> manually was successful.
>
> +1 Release this package as Apache Jackrabbit Filevault 3.4.10
>
> Regards
> Marcel
>
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,
On 26.02.21, 09:56, "Konrad Windszus" <ko...@gmx.de> wrote:
> Please vote on releasing this package as Apache Jackrabbit Filevault
> 3.4.10. The vote is open for a minimum of 72 hours during business days
> and passes if a majority of at least three +1 Jackrabbit PMC votes are
> cast. The vote fails if not enough votes are cast after 1 week (5
> business days).
The release check script failed with:
[INFO] Comparing sources...
[INFO]
Only in ./target/jackrabbit-filevault-3.4.10/zip/jackrabbit-filevault-3.4.10/vault-core: derby.log
[ERROR] NOT OK: Tagged sources are different from those in the archive
I don't consider this a release blocker. Running tests on the source release
manually was successful.
+1 Release this package as Apache Jackrabbit Filevault 3.4.10
Regards
Marcel
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Julian Reschke <ju...@gmx.de>.
Am 26.02.2021 um 09:56 schrieb Konrad Windszus:
> Hi,
> A candidate for the Jackrabbit Filevault 3.4.10 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.10/
>
> The release notes can be found at https://issues.apache.org/jira/projects/JCRVLT/versions/12349480
>
> The release candidate is a zip archive of the sources in:
>
> https://github.com/apache/jackrabbit-filevault/tree/jackrabbit-filevault-3.4.10/
>
> The SHA1 checksum of the archive is 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9.
> The SHA512 checksum of the archive is 02791f91a7e2e62c192779349380a16d5f1d68ea4aa36ae273d609c885bfb55ca8a688e87d9510544505cd13b33e6099c3b26d7a9546f959ab05bd269ac50958
>
> The command for running automated checks against this release candidate is:
> $ sh check-release.sh filevault 3.4.10 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachejackrabbit-1539
>
> Please vote on releasing this package as Apache Jackrabbit Filevault 3.4.10.
> The vote is open for a minimum of 72 hours during business days and passes
> if a majority of at least three +1 Jackrabbit PMC votes are cast.
> The vote fails if not enough votes are cast after 1 week (5 business days).
>
> [ ] +1 Release this package as Apache Jackrabbit Filevault 3.4.10
> [ ] -1 Do not release this package because...
>
> Konrad
I'm getting:
> [ERROR] NOT OK: Tagged sources are different from those in the archive
Best regards, Julian
[RESULT] [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Konrad Windszus <ko...@gmx.de>.
Hi,
The vote passes as follows:
+1 Marcel, Robert and myself.
Thanks for voting. I'll push the release out.
Konrad
> On 26. Feb 2021, at 09:56, Konrad Windszus <ko...@gmx.de> wrote:
>
> Hi,
> A candidate for the Jackrabbit Filevault 3.4.10 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.10/
>
> The release notes can be found at https://issues.apache.org/jira/projects/JCRVLT/versions/12349480
>
> The release candidate is a zip archive of the sources in:
>
> https://github.com/apache/jackrabbit-filevault/tree/jackrabbit-filevault-3.4.10/
>
> The SHA1 checksum of the archive is 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9.
> The SHA512 checksum of the archive is 02791f91a7e2e62c192779349380a16d5f1d68ea4aa36ae273d609c885bfb55ca8a688e87d9510544505cd13b33e6099c3b26d7a9546f959ab05bd269ac50958
>
> The command for running automated checks against this release candidate is:
> $ sh check-release.sh filevault 3.4.10 38f3d8dcb1e99b7241dd6b6b09c58f63d05fd6f9
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachejackrabbit-1539
>
> Please vote on releasing this package as Apache Jackrabbit Filevault 3.4.10.
> The vote is open for a minimum of 72 hours during business days and passes
> if a majority of at least three +1 Jackrabbit PMC votes are cast.
> The vote fails if not enough votes are cast after 1 week (5 business days).
>
> [ ] +1 Release this package as Apache Jackrabbit Filevault 3.4.10
> [ ] -1 Do not release this package because...
>
> Konrad
Re: [VOTE] Release Apache Jackrabbit Filevault 3.4.10
Posted by Robert Munteanu <ro...@apache.org>.
On Fri, 2021-02-26 at 09:56 +0100, Konrad Windszus wrote:
> Please vote on releasing this package as Apache Jackrabbit Filevault
> 3.4.10.
> The vote is open for a minimum of 72 hours during business days and
> passes
> if a majority of at least three +1 Jackrabbit PMC votes are cast.
> The vote fails if not enough votes are cast after 1 week (5 business
> days).
+1, check pass after applying Julian's patch to ignore derby.log
[INFO] ------------------------------------------------------------------------
[INFO] Apache Maven 3.6.3 (SUSE 3.6.3-2.6)
[INFO] OS name: "linux", version: "5.10.16-1-default", arch: "amd64", family: "unix"
[INFO] Java version: 11.0.10, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-11-openjdk-11
[INFO] MAVEN_OPTS:
[INFO] ------------------------------------------------------------------------
[INFO] ALL CHECKS OK
[INFO] ------------------------------------------------------------------------
Thanks,
Robert