You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "twalthr (via GitHub)" <gi...@apache.org> on 2025/01/20 07:46:40 UTC
[PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
twalthr opened a new pull request, #26019:
URL: https://github.com/apache/flink/pull/26019
## What is the purpose of the change
This implements a first skeleton for integrating PTFs into the planner. The PR prepares the code base for implementing a corresponding StreamExecNode.
It also prepares the CompiledPlan but concrete RestoreTests will follow.
## Brief change log
- Integration into changelog inference
- Adjust rules for both constant and non-constant table functions
- Implement physical rel node
## Verifying this change
This change added tests and can be verified as follows: `ProcessTableFunctionTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on code in PR #26019:
URL: https://github.com/apache/flink/pull/26019#discussion_r1922231487
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.java:
##########
@@ -0,0 +1,128 @@
+/*
Review Comment:
good point, that's a mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26019:
URL: https://github.com/apache/flink/pull/26019#discussion_r1921955642
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.java:
##########
@@ -0,0 +1,128 @@
+/*
Review Comment:
shouldn't we put this into java/** folder
having it in scala is a bit confusing
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.java:
##########
@@ -0,0 +1,128 @@
+/*
Review Comment:
shouldn't we put this into java/** folder
having it in scala is a bit confusing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on PR #26019:
URL: https://github.com/apache/flink/pull/26019#issuecomment-2604167596
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26019:
URL: https://github.com/apache/flink/pull/26019#discussion_r1921955642
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.java:
##########
@@ -0,0 +1,128 @@
+/*
Review Comment:
shouldn't we put this into java/** folder?
having it in scala is a bit confusing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26019:
URL: https://github.com/apache/flink/pull/26019#issuecomment-2601882942
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "41a33df93125a357bed41eecbc97cbc04741f539",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "41a33df93125a357bed41eecbc97cbc04741f539",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 41a33df93125a357bed41eecbc97cbc04741f539 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26019:
URL: https://github.com/apache/flink/pull/26019#discussion_r1922300665
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalProcessTableFunction.java:
##########
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.physical.stream;
Review Comment:
Sorry I forgot to mention
the same issue with this class (it is in scala/* folder)
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalProcessTableFunctionRule.java:
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.physical.stream;
Review Comment:
Sorry I forgot to mention
the same issue with this class (it is in scala/* folder)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr merged PR #26019:
URL: https://github.com/apache/flink/pull/26019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #26019:
URL: https://github.com/apache/flink/pull/26019#issuecomment-2602446034
fyi: the failure seems to be fixed in later commits https://github.com/apache/flink/commit/1afe645f59fc5239cbe027f67d3c00dc0e66fbc6
rebase might help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on PR #26019:
URL: https://github.com/apache/flink/pull/26019#issuecomment-2602435634
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37076][table-planner] Support PTFs until ExecNode level [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on PR #26019:
URL: https://github.com/apache/flink/pull/26019#issuecomment-2602758856
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org