You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/16 12:17:26 UTC

[GitHub] [camel-k] SubhasmitaSw opened a new pull request, #3366: introduce spectrum option job

SubhasmitaSw opened a new pull request, #3366:
URL: https://github.com/apache/camel-k/pull/3366

   related: issue #3340 
   
   cc: @astefanutti 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] astefanutti commented on a diff in pull request #3366: introduce spectrum option job

Posted by GitBox <gi...@apache.org>.
astefanutti commented on code in PR #3366:
URL: https://github.com/apache/camel-k/pull/3366#discussion_r902757741


##########
pkg/builder/spectrum.go:
##########
@@ -124,6 +125,11 @@ func (t *spectrumTask) Do(ctx context.Context) v1.BuildStatus {
 		Stdout:        newStdW,
 		Stderr:        newStdW,
 		Recursive:     true,
+		Jobs:          jobs,

Review Comment:
   You can remove that line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] astefanutti commented on a diff in pull request #3366: introduce spectrum option job

Posted by GitBox <gi...@apache.org>.
astefanutti commented on code in PR #3366:
URL: https://github.com/apache/camel-k/pull/3366#discussion_r899024501


##########
pkg/builder/spectrum.go:
##########
@@ -124,6 +130,7 @@ func (t *spectrumTask) Do(ctx context.Context) v1.BuildStatus {
 		Stdout:        newStdW,
 		Stderr:        newStdW,
 		Recursive:     true,
+		jobs:          Jobs,

Review Comment:
   A suggestion could be:
   
   ```go
   if jobs := runtime.GOMAXPROCS(0); jobs > 1 {
   	options.Jobs = jobs
   }
   ```



##########
pkg/builder/spectrum.go:
##########
@@ -114,6 +115,11 @@ func (t *spectrumTask) Do(ctx context.Context) v1.BuildStatus {
 		newStdW = os.Stdout
 	}
 
+	Jobs := jobs

Review Comment:
   Does that compile?



##########
pkg/builder/spectrum.go:
##########
@@ -124,6 +130,7 @@ func (t *spectrumTask) Do(ctx context.Context) v1.BuildStatus {
 		Stdout:        newStdW,
 		Stderr:        newStdW,
 		Recursive:     true,
+		jobs:          Jobs,

Review Comment:
   It should probably be `Jobs` otherwise it's not public.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] SubhasmitaSw commented on a diff in pull request #3366: introduce spectrum option job

Posted by GitBox <gi...@apache.org>.
SubhasmitaSw commented on code in PR #3366:
URL: https://github.com/apache/camel-k/pull/3366#discussion_r899026616


##########
pkg/builder/spectrum.go:
##########
@@ -114,6 +115,11 @@ func (t *spectrumTask) Do(ctx context.Context) v1.BuildStatus {
 		newStdW = os.Stdout
 	}
 
+	Jobs := jobs

Review Comment:
   It did not show any error to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] tadayosi merged pull request #3366: introduce spectrum option job

Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3366:
URL: https://github.com/apache/camel-k/pull/3366


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] astefanutti commented on a diff in pull request #3366: introduce spectrum option job

Posted by GitBox <gi...@apache.org>.
astefanutti commented on code in PR #3366:
URL: https://github.com/apache/camel-k/pull/3366#discussion_r899028130


##########
pkg/builder/spectrum.go:
##########
@@ -114,6 +115,11 @@ func (t *spectrumTask) Do(ctx context.Context) v1.BuildStatus {
 		newStdW = os.Stdout
 	}
 
+	Jobs := jobs

Review Comment:
   The build is failing, and my mental compiler cannot figure where that `jobs` variable could come from :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] SubhasmitaSw commented on a diff in pull request #3366: introduce spectrum option job

Posted by GitBox <gi...@apache.org>.
SubhasmitaSw commented on code in PR #3366:
URL: https://github.com/apache/camel-k/pull/3366#discussion_r903296886


##########
pkg/builder/spectrum.go:
##########
@@ -124,6 +125,11 @@ func (t *spectrumTask) Do(ctx context.Context) v1.BuildStatus {
 		Stdout:        newStdW,
 		Stderr:        newStdW,
 		Recursive:     true,
+		Jobs:          jobs,

Review Comment:
   Done!
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org