[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19654: [WIP] Migrate to use ECR as docker cache instead of dockerhub

[GitBox <gi...@apache.org>]

leezu commented on a change in pull request #19654:
URL: https://github.com/apache/incubator-mxnet/pull/19654#discussion_r540691804



##########
File path: ci/build.py
##########
@@ -117,6 +123,8 @@ def run_cmd():
     image_id = _get_local_image_id(docker_tag=tag)
     if not image_id:
         raise FileNotFoundError('Unable to find docker image id matching with {}'.format(tag))
+    # now that we've built the container, push it to our docker cache
+    push_docker_cache(registry, tag, image_id)

Review comment:
       This would be executed on developer machines as well. Is it necessary to trigger the push here? Currently we have a separate `docker-compose push` call in the Jenkins pipeline




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org