[jira] [Commented] (MAPREDUCE-4642) MiniMRClientClusterFactory should not use job.setJar()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450214#comment-13450214 ] 

Hadoop QA commented on MAPREDUCE-4642:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544133/MAPREDUCE-4642.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2826//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2826//console

This message is automatically generated.
                
> MiniMRClientClusterFactory should not use job.setJar()
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4642
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4642
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: MAPREDUCE-4642.patch
>
>
> Currently, MiniMRClientClusterFactory does {{job.setJar(callerJar)}} so that the {{callerJar}} is added to the cache in MR2.  However, this makes the resulting configuration inconsistent between MR1 and MR2 as in MR1 the job jar is not set and in MR2 its set to the {{callerJar}}.  This difference can also cause some tests to fail in Oozie.  We should instead use the {{job.addCacheFile()}} method.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira