[GitHub] merlimat commented on a change in pull request #1006: Acknowledgement with properties for RawReader

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1006: Acknowledgement with properties for RawReader
URL: https://github.com/apache/incubator-pulsar/pull/1006#discussion_r159182564
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/proto/PulsarApi.java
 ##########
 @@ -270,13 +270,13 @@ private ProtocolVersion(int index, int value) {
       com.google.protobuf.GeneratedMessageLite
       implements MessageIdDataOrBuilder, org.apache.pulsar.common.util.protobuf.ByteBufCodedOutputStream.ByteBufGeneratedMessage  {
     // Use MessageIdData.newBuilder() to construct.
-    private final io.netty.util.Recycler.Handle<MessageIdData> handle;
-    private MessageIdData(io.netty.util.Recycler.Handle<MessageIdData> handle) {
+    private io.netty.util.Recycler.Handle handle;
 
 Review comment:
   We have updated the patched `protoc` to use the generic `Recycler` that was introduced in Netty-4.1. Can you regenerate the code from the latest build image?
   
   ```shell
   docker pull apachepulsar/pulsar-build:latest
   cd ${PULSAR_HOME}/pulsar-common/
   ./generate_protobuf_docker.sh
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services