You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/10 03:03:29 UTC
[GitHub] [spark] linhongliu-db commented on a change in pull request #29673: [SPARK-32816][SQL] Fix analyzer bug when aggregating multiple distinct DECIMAL columns
linhongliu-db commented on a change in pull request #29673:
URL: https://github.com/apache/spark/pull/29673#discussion_r486034720
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2555,6 +2555,15 @@ class DataFrameSuite extends QueryTest
val df = Seq(0.0 -> -0.0).toDF("pos", "neg")
checkAnswer(df.select($"pos" > $"neg"), Row(false))
}
+
+ test("SPARK-32816: aggregating multiple distinct DECIMAL columns") {
+ spark.range(0, 100, 1, 1)
+ .selectExpr("id", "cast(id as decimal(9, 0)) as decimal_col")
+ .createOrReplaceTempView("test_table")
Review comment:
let me try this, I'm not sure if literal will behave differently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org