You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tajo.apache.org by Dongjoon Hyun <do...@apache.org> on 2015/03/17 16:23:57 UTC

Question about Tajo Maven Build Test

Hi, All.

Now, as you know, Tajo build has been broken up to know.
( https://travis-ci.org/apache/tajo/builds/54509653 )

I think it will recover as soon as possible at next build.
( https://travis-ci.org/apache/tajo/builds/54674072 )

However, here I have a question.

As far as I know, Travis builds Tajo by using the following command in
parallel mode.

$ mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=WARN
-Dmaven.fork.count=2

But, in the documentation of QueryTestCaseBase.java, I found the following
note.

"Note that this class is not thread safe. Do not execute maven test in any
parallel mode."

I need Committer's help. What is the best way you used to verify your code
for Tajo.

Best regards,
Dongjoon.

Re: Question about Tajo Maven Build Test

Posted by Dongjoon Hyun <do...@apache.org>.
Thank you for your quick and kind response, Jihun!

I was confused, and now I understand. :)

Regards,
Dongjoon.

On Wed, Mar 18, 2015 at 1:25 AM, Jihun Kang <yk...@gmail.com> wrote:

> Hello.
>
> parallel-test profile comes from the idea to reduce the execution time for
> tajo core maven module. I feel that we need to resolve this issue for build
> time on travis ci. Fortunately, Maven provides two mode for running test
> cases parallelly. One is running test cases in completely separate java
> processes. And later one is running test cases on multiple threads. I chose
> first one because some test cases are not thread safe, you know, and some
> features of maven parallel mode produce some critical issues.
> Running maven test cases will be one of code verification processes, I
> think.
> 2015. 3. 18. 오전 12:24에 "Dongjoon Hyun" <do...@apache.org>님이 작성:
>
> > Hi, All.
> >
> > Now, as you know, Tajo build has been broken up to know.
> > ( https://travis-ci.org/apache/tajo/builds/54509653 )
> >
> > I think it will recover as soon as possible at next build.
> > ( https://travis-ci.org/apache/tajo/builds/54674072 )
> >
> > However, here I have a question.
> >
> > As far as I know, Travis builds Tajo by using the following command in
> > parallel mode.
> >
> > $ mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=WARN
> > -Dmaven.fork.count=2
> >
> > But, in the documentation of QueryTestCaseBase.java, I found the
> following
> > note.
> >
> > "Note that this class is not thread safe. Do not execute maven test in
> any
> > parallel mode."
> >
> > I need Committer's help. What is the best way you used to verify your
> code
> > for Tajo.
> >
> > Best regards,
> > Dongjoon.
> >
>

Re: Question about Tajo Maven Build Test

Posted by Jihun Kang <yk...@gmail.com>.
Hello.

parallel-test profile comes from the idea to reduce the execution time for
tajo core maven module. I feel that we need to resolve this issue for build
time on travis ci. Fortunately, Maven provides two mode for running test
cases parallelly. One is running test cases in completely separate java
processes. And later one is running test cases on multiple threads. I chose
first one because some test cases are not thread safe, you know, and some
features of maven parallel mode produce some critical issues.
Running maven test cases will be one of code verification processes, I
think.
2015. 3. 18. 오전 12:24에 "Dongjoon Hyun" <do...@apache.org>님이 작성:

> Hi, All.
>
> Now, as you know, Tajo build has been broken up to know.
> ( https://travis-ci.org/apache/tajo/builds/54509653 )
>
> I think it will recover as soon as possible at next build.
> ( https://travis-ci.org/apache/tajo/builds/54674072 )
>
> However, here I have a question.
>
> As far as I know, Travis builds Tajo by using the following command in
> parallel mode.
>
> $ mvn clean install -Pparallel-test,hcatalog-0.12.0 -DLOG_LEVEL=WARN
> -Dmaven.fork.count=2
>
> But, in the documentation of QueryTestCaseBase.java, I found the following
> note.
>
> "Note that this class is not thread safe. Do not execute maven test in any
> parallel mode."
>
> I need Committer's help. What is the best way you used to verify your code
> for Tajo.
>
> Best regards,
> Dongjoon.
>