You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2017/12/21 09:21:02 UTC
[GitHub] carbondata pull request #1704: [CARBONDATA-1918] Incorrect data is displayed...
GitHub user dhatchayani opened a pull request:
https://github.com/apache/carbondata/pull/1704
[CARBONDATA-1918] Incorrect data is displayed when String is updated using Sentences
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [x] Testing done
UT Added
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhatchayani/incubator-carbondata sentences
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1704.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1704
----
commit 971d34519beb2f9f45f41cfbea3d112357631573
Author: dhatchayani <dh...@...>
Date: 2017-12-20T12:46:10Z
[CARBONDATA-1918] Incorrect data is displayed when String is updated using Sentences
----
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3258/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1704
retest this please
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2217/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1704
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3077/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2001/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3447/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1972/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3094/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2207/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1704
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3309/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3233/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1863/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3235/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3206/
---
[GitHub] carbondata pull request #1704: [CARBONDATA-1918] Incorrect data is displayed...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1704#discussion_r165368872
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala ---
@@ -206,6 +208,30 @@ case class CarbonIUDAnalysisRule(sparkSession: SparkSession) extends Rule[Logica
table)
}
}
+
+
+ /**
+ * This method will check whether the data type of new value is supported or not
+ * For example, arrayType is not supported
+ */
+ def checkForUnsupportedType(selectStmt: String): Unit = {
+ // selectStmt will have "select 'newValue' from table"
+ // we can validate the new value by executing the select query
+ val sel = selectStmt.substring(0, selectStmt.lastIndexOf("from")).trim;
--- End diff --
Better not to add this type of check ,
replace dataSet = sparkSession.sql(selectStmt).collect() directly for any case it will execute and get the rows
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1704
Please describe the PR
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/1704
Retest this please
---
[GitHub] carbondata pull request #1704: [CARBONDATA-1918] Incorrect data is displayed...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1704
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2009/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1999/
---
[GitHub] carbondata pull request #1704: [CARBONDATA-1918] Incorrect data is displayed...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1704#discussion_r165369872
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala ---
@@ -206,6 +208,30 @@ case class CarbonIUDAnalysisRule(sparkSession: SparkSession) extends Rule[Logica
table)
}
}
+
+
+ /**
+ * This method will check whether the data type of new value is supported or not
+ * For example, arrayType is not supported
+ */
+ def checkForUnsupportedType(selectStmt: String): Unit = {
+ // selectStmt will have "select 'newValue' from table"
+ // we can validate the new value by executing the select query
+ val sel = selectStmt.substring(0, selectStmt.lastIndexOf("from")).trim;
--- End diff --
Instead of getting from the data set , can we get a logical plan and check the data type
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3243/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1704
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3213/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2021/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1704
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3199/
---
[GitHub] carbondata issue #1704: [WIP][CARBONDATA-1918] Incorrect data is displayed w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1704
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3189/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/995/
---
[GitHub] carbondata issue #1704: [CARBONDATA-1918] Incorrect data is displayed when S...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1704
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/990/
---