You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/01/27 18:25:46 UTC

[GitHub] [datasketches-cpp] AlexanderSaydakov commented on pull request #185: Matches the Theta interface of the Java implementation

AlexanderSaydakov commented on pull request #185:
URL: https://github.com/apache/datasketches-cpp/pull/185#issuecomment-768482414


   It seems that this change breaks something in Python wrapper.
   I never liked this mixed union functionality. In my view it is just unnecessary complexity. That is why I did not implement it in C++.
   There is a complication: we have a new implementation of Theta sketch, which was developed as a part of Tuple sketch effort. The goal was to have a common base for both Theta and Tuple sketches. Currently this new Theta sketch implementation is sitting under Tuple sketch as experimental. I think it is time to make the move: replace the existing Theta sketch with this new implementation. I think it would be better to make sure that your integration works with this new version.
   Perhaps we could add these update methods to the Theta and Tuple unions, but I still think that they are not necessary.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org