You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/09/12 00:52:17 UTC
[Impala-ASF-CR] IMPALA-13376: Fix documentation for AGG MEM CORRELATION FACTOR
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21793
Change subject: IMPALA-13376: Fix documentation for AGG_MEM_CORRELATION_FACTOR
......................................................................
IMPALA-13376: Fix documentation for AGG_MEM_CORRELATION_FACTOR
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix the documentation issue.
Testing:
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
---
M common/thrift/ImpalaService.thrift
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/21793/1
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 6: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/800/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Sep 2024 23:44:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21793
to look at the new patch set (#3).
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and
LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0.
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix documentation in thrift file as well.
Testing:
- Run "make plain-html" in docs/ dir and confirm the output.
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
---
M common/thrift/ImpalaService.thrift
M docs/impala.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
A docs/topics/impala_agg_mem_correlation_factor.xml
A docs/topics/impala_large_agg_mem_threshold.xml
6 files changed, 152 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/21793/3
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13376: Fix documentation for AGG MEM CORRELATION FACTOR
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Fix documentation for AGG_MEM_CORRELATION_FACTOR
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16931/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 01:23:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 24 Sep 2024 17:10:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21793
to look at the new patch set (#2).
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and
LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0.
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix documentation in thrift file as well.
Testing:
- Run "make plain-html" in docs/ dir and confirm the output.
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
---
M common/thrift/ImpalaService.thrift
M docs/impala.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
A docs/topics/impala_agg_mem_correlation_factor.xml
A docs/topics/impala_large_agg_mem_threshold.xml
6 files changed, 152 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/21793/2
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/796/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 15:40:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 5: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/799/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 22:04:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/794/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 13 Sep 2024 23:21:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap
File docs/impala.ditamap:
http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap@206
PS4, Line 206: <topicref href="topics/impala_explain_level.xml"/>
> side note: I'm not sure why this is nested under explain_level
Seems like a bug, looking how the outcome is: https://impala.apache.org/docs/build/plain-html/index.html
Took this out of impala_explain_level.xml
http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap@246
PS4, Line 246: <topicref href="topics/impala_resource_trace_ratio.xml"/>
> These are organized alphabetically. How did you decide to add it here?
My bad, I thought the generator can sort them automatically.
Put them alphabetically now.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 21:59:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 6:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/800/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Sep 2024 23:36:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/796/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 15:48:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Fix documentation for AGG MEM CORRELATION FACTOR
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Fix documentation for AGG_MEM_CORRELATION_FACTOR
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21793/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21793/1//COMMIT_MSG@7
PS1, Line 7: documentation
Just curious, the patch fixes a comment in thrift, will the change also affect the documentation somewhere?
http://gerrit.cloudera.org:8080/#/c/21793/1//COMMIT_MSG@12
PS1, Line 12: fix
nit. fixes
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 13 Sep 2024 04:39:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_agg_mem_correlation_factor.xml
File docs/topics/impala_agg_mem_correlation_factor.xml:
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_agg_mem_correlation_factor.xml@39
PS2, Line 39: 4.0.0
is it 4.4.0?
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_large_agg_mem_threshold.xml
File docs/topics/impala_large_agg_mem_threshold.xml:
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_large_agg_mem_threshold.xml@39
PS2, Line 39: 4.0.0
is it 4.4.0?
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 02:43:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 5:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/799/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 21:57:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21793/5/docs/topics/impala_large_agg_mem_threshold.xml
File docs/topics/impala_large_agg_mem_threshold.xml:
http://gerrit.cloudera.org:8080/#/c/21793/5/docs/topics/impala_large_agg_mem_threshold.xml@55
PS5, Line 55: MB
> Is this MB?
Yes, thanks for catching this!
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Sep 2024 23:37:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_agg_mem_correlation_factor.xml
File docs/topics/impala_agg_mem_correlation_factor.xml:
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_agg_mem_correlation_factor.xml@39
PS2, Line 39: 4.4.0
> is it 4.4.0?
Done
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_large_agg_mem_threshold.xml
File docs/topics/impala_large_agg_mem_threshold.xml:
http://gerrit.cloudera.org:8080/#/c/21793/2/docs/topics/impala_large_agg_mem_threshold.xml@39
PS2, Line 39: 4.4.0
> is it 4.4.0?
Done
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 05:02:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21793/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21793/1//COMMIT_MSG@7
PS1, Line 7: docs for AGG_
> We should add documentation for this query option under docs/. It does not
Repurposed this patch to write proper documentation about these options.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 13 Sep 2024 23:15:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/795/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 05:02:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 22:50:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and
LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0.
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix documentation in thrift file as well.
Testing:
- Run "make plain-html" in docs/ dir and confirm the output.
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Reviewed-on: http://gerrit.cloudera.org:8080/21793
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
---
M common/thrift/ImpalaService.thrift
M docs/impala.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
A docs/topics/impala_agg_mem_correlation_factor.xml
A docs/topics/impala_large_agg_mem_threshold.xml
6 files changed, 161 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Smith: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 05:08:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/795/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 05:12:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21793/5/docs/topics/impala_large_agg_mem_threshold.xml
File docs/topics/impala_large_agg_mem_threshold.xml:
http://gerrit.cloudera.org:8080/#/c/21793/5/docs/topics/impala_large_agg_mem_threshold.xml@55
PS5, Line 55: KB
Is this MB?
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Sep 2024 20:41:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Fix documentation for AGG MEM CORRELATION FACTOR
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Fix documentation for AGG_MEM_CORRELATION_FACTOR
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 20:16:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/794/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 13 Sep 2024 23:14:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Fix documentation for AGG MEM CORRELATION FACTOR
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Fix documentation for AGG_MEM_CORRELATION_FACTOR
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21793/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21793/1//COMMIT_MSG@7
PS1, Line 7: documentation
> Just curious, the patch fixes a comment in thrift, will the change also aff
We should add documentation for this query option under docs/. It does not have any now.
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 13 Sep 2024 18:10:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap
File docs/impala.ditamap:
http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap@206
PS4, Line 206: <topicref rev="2.5.0" href="topics/impala_max_num_runtime_filters.xml"/>
side note: I'm not sure why this is nested under explain_level
http://gerrit.cloudera.org:8080/#/c/21793/4/docs/impala.ditamap@246
PS4, Line 246: <topicref rev="4.4.0" href="topics/impala_agg_mem_correlation_factor.xml"/>
These are organized alphabetically. How did you decide to add it here?
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 21:06:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21793
to look at the new patch set (#5).
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and
LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0.
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix documentation in thrift file as well.
Testing:
- Run "make plain-html" in docs/ dir and confirm the output.
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
---
M common/thrift/ImpalaService.thrift
M docs/impala.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
A docs/topics/impala_agg_mem_correlation_factor.xml
A docs/topics/impala_large_agg_mem_threshold.xml
6 files changed, 161 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/21793/5
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21793
to look at the new patch set (#4).
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and
LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0.
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix documentation in thrift file as well.
Testing:
- Run "make plain-html" in docs/ dir and confirm the output.
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
---
M common/thrift/ImpalaService.thrift
M docs/impala.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
A docs/topics/impala_agg_mem_correlation_factor.xml
A docs/topics/impala_large_agg_mem_threshold.xml
6 files changed, 158 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/21793/4
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21793 )
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
Patch Set 4:
ps4 update the docs to follow example from topics/impala_max_row_size.xml
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Sep 2024 15:42:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13376: Add docs for AGG MEM CORRELATION FACTOR etc
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21793
to look at the new patch set (#6).
Change subject: IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
......................................................................
IMPALA-13376: Add docs for AGG_MEM_CORRELATION_FACTOR etc
This patch adds documentation for AGG_MEM_CORRELATION_FACTOR and
LARGE_AGG_MEM_THRESHOLD option introduced in Apache Impala 4.4.0.
IMPALA-12548 fix behavior of AGG_MEM_CORRELATION_FACTOR. Higher value
will lower memory estimation, while lower value will result in higher
memory estimation. The documentation in ImpalaService.thrift, however,
says the opposite. This patch fix documentation in thrift file as well.
Testing:
- Run "make plain-html" in docs/ dir and confirm the output.
- Manually check with comments in
PlannerTest.testAggNodeMaxMemEstimate()
Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
---
M common/thrift/ImpalaService.thrift
M docs/impala.ditamap
M docs/shared/ImpalaVariables.xml
M docs/shared/impala_common.xml
A docs/topics/impala_agg_mem_correlation_factor.xml
A docs/topics/impala_large_agg_mem_threshold.xml
6 files changed, 161 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/21793/6
--
To view, visit http://gerrit.cloudera.org:8080/21793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00956a50fb7616ca3c3ea2fd75fd11239a6bcd90
Gerrit-Change-Number: 21793
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>