You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2015/02/18 04:41:06 UTC

Review Request 31149: Add test to support current & last week el expression

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31149/
-----------------------------------------------------------

Review request for Falcon and Raghav Gautam.


Bugs: FALCON-843
    https://issues.apache.org/jira/browse/FALCON-843


Repository: falcon-git


Description
-------

Test to be added for support current & last week as part of https://issues.apache.org/jira/browse/FALCON-554


Diffs
-----

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/31149/diff/


Testing
-------

Done


Thanks,

PRAGYA MITTAL

Re: Review Request 31149: Add test to support current & last week el expression

Posted by samarth gupta <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31149/#review74222
-----------------------------------------------------------

Ship it!


Ship It!

- samarth gupta


On Feb. 19, 2015, 5:52 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31149/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 5:52 p.m.)
> 
> 
> Review request for Falcon and Raghav Gautam.
> 
> 
> Bugs: FALCON-843
>     https://issues.apache.org/jira/browse/FALCON-843
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test to be added for support current & last week as part of https://issues.apache.org/jira/browse/FALCON-554
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31149/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>

Re: Review Request 31149: Add test to support current & last week el expression

Posted by PRAGYA MITTAL <mi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31149/
-----------------------------------------------------------

(Updated Feb. 19, 2015, 5:52 p.m.)


Review request for Falcon and Raghav Gautam.


Bugs: FALCON-843
    https://issues.apache.org/jira/browse/FALCON-843


Repository: falcon-git


Description
-------

Test to be added for support current & last week as part of https://issues.apache.org/jira/browse/FALCON-554


Diffs (updated)
-----

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/31149/diff/


Testing
-------

Done


Thanks,

PRAGYA MITTAL

Re: Review Request 31149: Add test to support current & last week el expression

Posted by PRAGYA MITTAL <mi...@gmail.com>.


> On Feb. 19, 2015, 3:50 p.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java, lines 181-197
> > <https://reviews.apache.org/r/31149/diff/1/?file=867257#file867257line181>
> >
> >     TimeUtil.getMinuteDatesOnEitherSide(String startOozieDate, String endOozieDate, int minuteSkip, DateTimeFormatter formatter) should be used with SimpleDateFormat("yyyy/MM/dd/HH/mm")

This approach look way better. Thanks.


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31149/#review73150
-----------------------------------------------------------


On Feb. 18, 2015, 3:41 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31149/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 3:41 a.m.)
> 
> 
> Review request for Falcon and Raghav Gautam.
> 
> 
> Bugs: FALCON-843
>     https://issues.apache.org/jira/browse/FALCON-843
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test to be added for support current & last week as part of https://issues.apache.org/jira/browse/FALCON-554
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31149/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>

Re: Review Request 31149: Add test to support current & last week el expression

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31149/#review73150
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119372>

    we should import only classes that are used



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119376>

    not used



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119374>

    can be local in @BeforeMethod



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119373>

    we can just use bundles[0].getProcessName() once again here without creating another String



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119375>

    there is no reason to create empty list here



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java
<https://reviews.apache.org/r/31149/#comment119377>

    TimeUtil.getMinuteDatesOnEitherSide(String startOozieDate, String endOozieDate, int minuteSkip, DateTimeFormatter formatter) should be used with SimpleDateFormat("yyyy/MM/dd/HH/mm")


- Ruslan Ostafiychuk


On Feb. 18, 2015, 3:41 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31149/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 3:41 a.m.)
> 
> 
> Review request for Falcon and Raghav Gautam.
> 
> 
> Bugs: FALCON-843
>     https://issues.apache.org/jira/browse/FALCON-843
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Test to be added for support current & last week as part of https://issues.apache.org/jira/browse/FALCON-554
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31149/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>