You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2014/07/01 03:57:54 UTC
Fwd: Delivery Status Notification (Failure)
Can we get rid of the _ prefix in ivar names please.
Gary
On Mon, Jun 30, 2014 at 8:36 PM, <ma...@apache.org> wrote:
> Author: mattsicker
> Date: Tue Jul 1 00:36:24 2014
> New Revision: 1606954
>
> URL: http://svn.apache.org/r1606954
> Log:
> Fix strange compilation error noted in LOG4J2-694.
>
> - Although this field could theoretically be final, javac does not
> appear to think so!
>
> Modified:
>
>
logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
>
> Modified:
>
logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> URL:
>
http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java?rev=1606954&r1=1606953&r2=1606954&view=diff
>
>
==============================================================================
> ---
>
logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> (original)
> +++
>
logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> Tue Jul 1 00:36:24 2014
> @@ -152,7 +152,7 @@ public class PerfTestDriver {
> long _pct99_99;
> double _latencyRowCount;
> int _throughputRowCount;
> - private final long _averageOpsPerSec;
> + private long _averageOpsPerSec;
>
> // example line: avg=828 99%=1118 99.99%=5028 Count=3125
> public Stats(final String raw) {
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Delivery Status Notification (Failure)
Posted by Gary Gregory <ga...@gmail.com>.
Yes, sorry about the email subject. I must have mixed up messages...
Gary
On Tue, Jul 1, 2014 at 11:19 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> Odd email subject.
>
> But +1 to changing the variable names.
>
> Ralph
>
> On Jun 30, 2014, at 6:57 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Can we get rid of the _ prefix in ivar names please.
>
> Gary
>
>
> On Mon, Jun 30, 2014 at 8:36 PM, <ma...@apache.org> wrote:
>
> > Author: mattsicker
> > Date: Tue Jul 1 00:36:24 2014
> > New Revision: 1606954
> >
> > URL: http://svn.apache.org/r1606954
> > Log:
> > Fix strange compilation error noted in LOG4J2-694.
> >
> > - Although this field could theoretically be final, javac does not
> > appear to think so!
> >
> > Modified:
> >
> >
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> >
> > Modified:
> >
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> > URL:
> >
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java?rev=1606954&r1=1606953&r2=1606954&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> > (original)
> > +++
> >
> logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> > Tue Jul 1 00:36:24 2014
> > @@ -152,7 +152,7 @@ public class PerfTestDriver {
> > long _pct99_99;
> > double _latencyRowCount;
> > int _throughputRowCount;
> > - private final long _averageOpsPerSec;
> > + private long _averageOpsPerSec;
> >
> > // example line: avg=828 99%=1118 99.99%=5028 Count=3125
> > public Stats(final String raw) {
> >
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Delivery Status Notification (Failure)
Posted by Ralph Goers <ra...@dslextreme.com>.
Odd email subject.
But +1 to changing the variable names.
Ralph
On Jun 30, 2014, at 6:57 PM, Gary Gregory <ga...@gmail.com> wrote:
> Can we get rid of the _ prefix in ivar names please.
>
> Gary
>
>
> On Mon, Jun 30, 2014 at 8:36 PM, <ma...@apache.org> wrote:
>
> > Author: mattsicker
> > Date: Tue Jul 1 00:36:24 2014
> > New Revision: 1606954
> >
> > URL: http://svn.apache.org/r1606954
> > Log:
> > Fix strange compilation error noted in LOG4J2-694.
> >
> > - Although this field could theoretically be final, javac does not
> > appear to think so!
> >
> > Modified:
> >
> > logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> >
> > Modified:
> > logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> > URL:
> > http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java?rev=1606954&r1=1606953&r2=1606954&view=diff
> >
> > ==============================================================================
> > ---
> > logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> > (original)
> > +++
> > logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTestDriver.java
> > Tue Jul 1 00:36:24 2014
> > @@ -152,7 +152,7 @@ public class PerfTestDriver {
> > long _pct99_99;
> > double _latencyRowCount;
> > int _throughputRowCount;
> > - private final long _averageOpsPerSec;
> > + private long _averageOpsPerSec;
> >
> > // example line: avg=828 99%=1118 99.99%=5028 Count=3125
> > public Stats(final String raw) {
> >
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory