You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/07/26 22:43:38 UTC
[PR] [SPARK-58355][SS] Fix grammar in metadata log null-check message [spark]
uros-b opened a new pull request, #57546:
URL: https://github.com/apache/spark/pull/57546
### What changes were proposed in this pull request?
Fixes the grammar of the null-metadata `require(...)` message in `HDFSMetadataLog` and `AsyncOffsetSeqLog`: ""'null' metadata cannot written to a metadata log"" becomes ""... cannot be written ..."".
### Why are the changes needed?
The message was missing the word ""be"". The sibling `AsyncCommitLog` already uses the correct phrasing, so this brings the two outliers in line. The message is a plain `require()` string, not part of the error-condition framework, so it is not golden-tested.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Message-text-only change; no behavior change. No tests needed.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58355][SS] Fix grammar in metadata log null-check message [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57546:
URL: https://github.com/apache/spark/pull/57546#issuecomment-5090775240
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/a663376d954fc950cc949d5f0a9d385cb262edfb
- merged into branch-4.x https://github.com/apache/spark/commit/ee7b61c54c5698d952de1d98f6fcf2d3558830b3
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58355][SS] Fix grammar in metadata log null-check message [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57546: [SPARK-58355][SS] Fix grammar in metadata log null-check message
URL: https://github.com/apache/spark/pull/57546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org