Why are uptodate parser/lexer checks disabled?

[Dmitriy Ryaboy <dv...@gmail.com>]

Pig build keeps pausing noticeably in the genParser and genTreeParser
tasks, even when the grammar hasn't changed. This seems to be due to the
following commented out bit of build.xml:

 <target name="prepare">
   <uptodate property="lexerGrammarProcessed" srcfile="${grammar.src.dir}/${
grammar.name}Lexer.g">
     <mapper type="merge" to="${src.gen.dir}/${grammar.package.dir}/${
grammar.name}Lexer.java"/>
   </uptodate>*<!--
   <uptodate property="parserGrammarProcessed"
srcfile="${grammar.src.dir}/${grammar.name}Parser.g">
     <mapper type="merge" to="${src.gen.dir}/${grammar.package.dir}/${
grammar.name}Parser.java"/>
   </uptodate>
   <uptodate property="treeGrammarProcessed" srcfile="${grammar.src.dir}/${
grammar.name}Tree.g">
     <mapper type="merge" to="${src.gen.dir}/${gramar.package.dir}/${
grammar.name}Tree.java"/>
   </uptodate>-->*
   <!--mkdir dir="build/classes"/-->
   <mkdir dir="${src.gen.dir}/${grammar.package.dir}"/>
 </target>

Why is that disabled? I tested uncommenting the first of these, and it
appears to "just work." The second one is a bit trickier.. but each shaves
at least 5 seconds off build time.

Re: Why are uptodate parser/lexer checks disabled?

[Gianmarco De Francisci Morales <gd...@apache.org>]

Hi Dmitriy,

I don't have an answer but in general build.xml needs a bit of face-lifting.
Let's fix this :)
--
Gianmarco



On Tue, Jan 17, 2012 at 02:34, Dmitriy Ryaboy <dv...@gmail.com> wrote:

> Pig build keeps pausing noticeably in the genParser and genTreeParser
> tasks, even when the grammar hasn't changed. This seems to be due to the
> following commented out bit of build.xml:
>
>  <target name="prepare">
>   <uptodate property="lexerGrammarProcessed" srcfile="${grammar.src.dir}/${
> grammar.name}Lexer.g">
>     <mapper type="merge" to="${src.gen.dir}/${grammar.package.dir}/${
> grammar.name}Lexer.java"/>
>   </uptodate>*<!--
>   <uptodate property="parserGrammarProcessed"
> srcfile="${grammar.src.dir}/${grammar.name}Parser.g">
>     <mapper type="merge" to="${src.gen.dir}/${grammar.package.dir}/${
> grammar.name}Parser.java"/>
>   </uptodate>
>   <uptodate property="treeGrammarProcessed" srcfile="${grammar.src.dir}/${
> grammar.name}Tree.g">
>     <mapper type="merge" to="${src.gen.dir}/${gramar.package.dir}/${
> grammar.name}Tree.java"/>
>   </uptodate>-->*
>   <!--mkdir dir="build/classes"/-->
>   <mkdir dir="${src.gen.dir}/${grammar.package.dir}"/>
>  </target>
>
> Why is that disabled? I tested uncommenting the first of these, and it
> appears to "just work." The second one is a bit trickier.. but each shaves
> at least 5 seconds off build time.
>