[GitHub] [netbeans] DevCharly commented on a change in pull request #1858: [NETBEANS-3428] Update FlatLaf from 0.23 to 0.24 and other fixes

[GitBox <gi...@apache.org>]

DevCharly commented on a change in pull request #1858: [NETBEANS-3428] Update FlatLaf from 0.23 to 0.24 and other fixes
URL: https://github.com/apache/netbeans/pull/1858#discussion_r365543233
 
 

 ##########
 File path: platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
 ##########
 @@ -877,7 +876,6 @@ public void addSeparator() {
             c.insets = new Insets(5, 5, 5, 5);
             c.fill = GridBagConstraints.HORIZONTAL;
             JSeparator separator = new JSeparator(JSeparator.HORIZONTAL);
-            separator.setForeground(SystemColor.controlShadow);
 
 Review comment:
   This are the two horizontal separators in the "Find in Projects" dialog (see screenshots above). In Windows LAF there is no difference because default separator foreground is already controlShadow. Did not check other LAFs, but even if there is difference, this should be no problem. Its just a simple separator in a dialog. Default separator colors should work fine in dialogs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists