You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by "Ruben D. Porras" <ru...@w2en.com> on 2017/06/07 15:54:01 UTC
Review Request 59883: Includes: - Adding eclipse generated files to
.gitignore - Support specifying a custom ShiroCredentialsMatcher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Includes:
- Adding eclipse generated files to .gitignore
- Support specifying a custom ShiroCredentialsMatcher
Diffs
-----
.gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
Diff: https://reviews.apache.org/r/59883/diff/1/
Testing
-------
Modify unit tests to add constructor parameter
Run Scheduler manually configured to check that still working properly
Thanks,
Ruben D. Porras
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177285
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:88: Line is longer than 100 characters (found 104). [LineLength]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 15.959 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 8, 2017, 7:09 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 7:09 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/3/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177287
-----------------------------------------------------------
Ship it!
Master (73234d0) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 8, 2017, 7:25 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 7:25 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On June 8, 2017, 7:48 p.m., David McLaughlin wrote:
> > Can you give a higher level description of what you're trying to achieve?
>
> Ruben D. Porras wrote:
> Allows to use a custom CredentialsMatchers...
>
> - using the command line argument **shiro_credentials_matcher** it's possible to specify which credentials matcher class has to be used in order to inject and use it as a credential matcher
> - in that way, it's possible to use credentials matchers that allows non plain passwords
>
>
> I've tested it implementing a credential matcher for bcrypt, then include the library in the classpath and providing the class with the argument **shiro_credentials_matcher**, so my **shiro.ini** contains bcrypted password.
I understood that part :)
I was asking because the (pretty simple) module you've modified is already pluggable in the Scheduler:
https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java#L76
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177359
-----------------------------------------------------------
On June 8, 2017, 7:25 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 7:25 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by "Ruben D. Porras" <ru...@w2en.com>.
> On June 8, 2017, 9:48 p.m., David McLaughlin wrote:
> > Can you give a higher level description of what you're trying to achieve?
>
> Ruben D. Porras wrote:
> Allows to use a custom CredentialsMatchers...
>
> - using the command line argument **shiro_credentials_matcher** it's possible to specify which credentials matcher class has to be used in order to inject and use it as a credential matcher
> - in that way, it's possible to use credentials matchers that allows non plain passwords
>
>
> I've tested it implementing a credential matcher for bcrypt, then include the library in the classpath and providing the class with the argument **shiro_credentials_matcher**, so my **shiro.ini** contains bcrypted password.
>
> David McLaughlin wrote:
> I understood that part :)
>
> I was asking because the (pretty simple) module you've modified is already pluggable in the Scheduler:
>
> https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java#L76
Ok,
this one covers this card https://issues.apache.org/jira/browse/AURORA-1179
and I think it's less intrusive that adding a new realm. it avoids to creates a new realm just to hash or ciph the passwords of an ini file.
- Ruben D.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177359
-----------------------------------------------------------
On June 8, 2017, 9:25 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 9:25 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by "Ruben D. Porras" <ru...@w2en.com>.
> On June 8, 2017, 9:48 p.m., David McLaughlin wrote:
> > Can you give a higher level description of what you're trying to achieve?
Allows to use a custom CredentialsMatchers...
- using the command line argument **shiro_credentials_matcher** it's possible to specify which credentials matcher class has to be used in order to inject and use it as a credential matcher
- in that way, it's possible to use credentials matchers that allows non plain passwords
I've tested it implementing a credential matcher for bcrypt, then include the library in the classpath and providing the class with the argument **shiro_credentials_matcher**, so my **shiro.ini** contains bcrypted password.
- Ruben D.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177359
-----------------------------------------------------------
On June 8, 2017, 9:25 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 9:25 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177359
-----------------------------------------------------------
Can you give a higher level description of what you're trying to achieve?
- David McLaughlin
On June 8, 2017, 7:25 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 7:25 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Support specifying a custom
ShiroCredentialsMatcher
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review178552
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On June 20, 2017, 10:47 p.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 10:47 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Support specifying a custom
ShiroCredentialsMatcher
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review178423
-----------------------------------------------------------
I will run the e2e tests and ship it in case they succeed.
- Stephan Erb
On June 20, 2017, 10:47 p.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 10:47 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Support specifying a custom
ShiroCredentialsMatcher
Posted by "Ruben D. Porras" <ru...@w2en.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/
-----------------------------------------------------------
(Updated June 20, 2017, 10:47 p.m.)
Review request for Aurora.
Summary (updated)
-----------------
Support specifying a custom ShiroCredentialsMatcher
Repository: aurora
Description
-------
Includes:
- Adding eclipse generated files to .gitignore
- Support specifying a custom ShiroCredentialsMatcher
Diffs
-----
.gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
Diff: https://reviews.apache.org/r/59883/diff/5/
Testing
-------
Modify unit tests to add constructor parameter
Run Scheduler manually configured to check that still working properly
Thanks,
Ruben D. Porras
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177655
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On June 8, 2017, 7:25 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 7:25 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/5/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by "Ruben D. Porras" <ru...@w2en.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/
-----------------------------------------------------------
(Updated June 8, 2017, 9:25 a.m.)
Review request for Aurora.
Changes
-------
fix style
Repository: aurora
Description
-------
Includes:
- Adding eclipse generated files to .gitignore
- Support specifying a custom ShiroCredentialsMatcher
Diffs (updated)
-----
.gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
Diff: https://reviews.apache.org/r/59883/diff/5/
Changes: https://reviews.apache.org/r/59883/diff/4-5/
Testing
-------
Modify unit tests to add constructor parameter
Run Scheduler manually configured to check that still working properly
Thanks,
Ruben D. Porras
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177286
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
:commons:generateThriftResources
:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:88: Line has trailing spaces. [RegexpSingleline]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 53.351 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 8, 2017, 9:14 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 9:14 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/4/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by "Ruben D. Porras" <ru...@w2en.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/
-----------------------------------------------------------
(Updated June 8, 2017, 9:14 a.m.)
Review request for Aurora.
Changes
-------
fix style
Repository: aurora
Description
-------
Includes:
- Adding eclipse generated files to .gitignore
- Support specifying a custom ShiroCredentialsMatcher
Diffs (updated)
-----
.gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
Diff: https://reviews.apache.org/r/59883/diff/4/
Changes: https://reviews.apache.org/r/59883/diff/3-4/
Testing
-------
Modify unit tests to add constructor parameter
Run Scheduler manually configured to check that still working properly
Thanks,
Ruben D. Porras
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by "Ruben D. Porras" <ru...@w2en.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/
-----------------------------------------------------------
(Updated June 8, 2017, 9:09 a.m.)
Review request for Aurora.
Changes
-------
fix style
Repository: aurora
Description
-------
Includes:
- Adding eclipse generated files to .gitignore
- Support specifying a custom ShiroCredentialsMatcher
Diffs (updated)
-----
.gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
Diff: https://reviews.apache.org/r/59883/diff/3/
Changes: https://reviews.apache.org/r/59883/diff/2-3/
Testing
-------
Modify unit tests to add constructor parameter
Run Scheduler manually configured to check that still working properly
Thanks,
Ruben D. Porras
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177284
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:25: Wrong order for 'com.google.common.annotations.VisibleForTesting' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ImportOrder]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:82: Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:88:39: 'ini' hides a field. [HiddenField]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 23.874 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 8, 2017, 8:56 a.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 8:56 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/2/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by "Ruben D. Porras" <ru...@w2en.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/
-----------------------------------------------------------
(Updated June 8, 2017, 6:56 a.m.)
Review request for Aurora.
Changes
-------
Fix style
Repository: aurora
Description
-------
Includes:
- Adding eclipse generated files to .gitignore
- Support specifying a custom ShiroCredentialsMatcher
Diffs (updated)
-----
.gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
Diff: https://reviews.apache.org/r/59883/diff/2/
Changes: https://reviews.apache.org/r/59883/diff/1-2/
Testing
-------
Modify unit tests to add constructor parameter
Run Scheduler manually configured to check that still working properly
Thanks,
Ruben D. Porras
Re: Review Request 59883: Includes: - Adding eclipse generated files
to .gitignore - Support specifying a custom ShiroCredentialsMatcher
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59883/#review177176
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
:assemble
:compileJmhJava
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.15/jmh-core-1.15.pom
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-parent/1.15/jmh-parent-1.15.pom
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.15/jmh-generator-annprocess-1.15.pom
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.15/jmh-core-1.15.jar
Download https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.15/jmh-generator-annprocess-1.15.jar
Download https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-annotations/2.5.1/jackson-annotations-2.5.1.pom
Download https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-annotations/2.5.1/jackson-annotations-2.5.1.jar
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
Download https://repo1.maven.org/maven2/com/puppycrawl/tools/checkstyle/7.3/checkstyle-7.3.pom
Download https://repo1.maven.org/maven2/com/puppycrawl/tools/checkstyle/7.3/checkstyle-7.3.jar
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:25: Wrong order for 'com.google.common.annotations.VisibleForTesting' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line. [ImportOrder]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:46: 'help' have incorrect indentation level 4, expected level should be 6. [Indentation]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:46:1: Line contains a tab character. [FileTabCharacter]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:47: Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:48:3: Line contains a tab character. [FileTabCharacter]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:54: Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:82: Line has trailing spaces. [RegexpSingleline]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:88:39: 'ini' hides a field. [HiddenField]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java:92: Line has trailing spaces. [RegexpSingleline]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 2 mins 50.248 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 7, 2017, 5:54 p.m., Ruben D. Porras wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59883/
> -----------------------------------------------------------
>
> (Updated June 7, 2017, 5:54 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Includes:
> - Adding eclipse generated files to .gitignore
> - Support specifying a custom ShiroCredentialsMatcher
>
>
> Diffs
> -----
>
> .gitignore d2d189d0cbe987cf9fe10878c39e6ba0dd88b38d
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 43c38dcffd8e68c018217681cc5a3073d9fb1437
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java d05ecebd6c3c1c6019c150ec449c1e1103222fbb
>
>
> Diff: https://reviews.apache.org/r/59883/diff/1/
>
>
> Testing
> -------
>
> Modify unit tests to add constructor parameter
> Run Scheduler manually configured to check that still working properly
>
>
> Thanks,
>
> Ruben D. Porras
>
>