You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/04/29 10:18:25 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1409: Remove useless type cast in redis_slot.cc
PragmaTwice opened a new pull request, #1409:
URL: https://github.com/apache/incubator-kvrocks/pull/1409
Mostly `uint64_t` and `int`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1409: Remove useless type cast in redis_slot.cc
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1409:
URL: https://github.com/apache/incubator-kvrocks/pull/1409#issuecomment-1528779781
Thanks all. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1409: Remove useless type cast in redis_slot.cc
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1409:
URL: https://github.com/apache/incubator-kvrocks/pull/1409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1409: Remove useless type cast in redis_slot.cc
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1409:
URL: https://github.com/apache/incubator-kvrocks/pull/1409#issuecomment-1528752404
> Can we have lint to find that some cast is useless?
Currently no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] mapleFU commented on pull request #1409: Remove useless type cast in redis_slot.cc
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #1409:
URL: https://github.com/apache/incubator-kvrocks/pull/1409#issuecomment-1528751433
Can we have lint to find that some cast is useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org