You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tvalentyn (via GitHub)" <gi...@apache.org> on 2025/03/26 22:30:28 UTC
[PR] Remove legacy setup.py clean command [beam]
tvalentyn opened a new pull request, #34443:
URL: https://github.com/apache/beam/pull/34443
I don't see any evidence of `python setup.py clean` doing any useful cleaning.
In a clean repo, I have built apache-beam via:
`python3 -m build --sdist`, and also installed via `pip install -e .`
This created 146 untracked files:
```
(py310) 15:29:09 ::python$ git ls-files . --ignored --exclude-standard --others | wc -l
146
```
The number didn't change after running `python setup.py clean`, so i don't see any value that it is adding, yet it requires additional deps and trips peoples's workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove legacy setup.py clean command [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #34443:
URL: https://github.com/apache/beam/pull/34443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove legacy setup.py clean command [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34443:
URL: https://github.com/apache/beam/pull/34443#issuecomment-2755886841
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove legacy setup.py clean command [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #34443:
URL: https://github.com/apache/beam/pull/34443#issuecomment-2755884752
r: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org