You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jdcasale (via GitHub)" <gi...@apache.org> on 2024/04/15 16:04:42 UTC

[PR] Modify decimal regex to accept positive exponent specifier [arrow-rs]

jdcasale opened a new pull request, #5649:
URL: https://github.com/apache/arrow-rs/pull/5649

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes https://github.com/apache/arrow-rs/issues/5648
   
   # Rationale for this change
   If users have float data in scientific format with a positive exponent specifier (e.g "3.106e+04"), the current csv inference mechanism does not work correctly. This change fixes that. 
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   This causes a change in schema inference behavior -- it's possible that some user relies on the fact that the current behavior is incorrect. I'm not sure what arrow's policy is around visible changes like this, so if this is change is not allowable I understand.
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Modify decimal regex to accept positive exponent specifier [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5649:
URL: https://github.com/apache/arrow-rs/pull/5649#issuecomment-2057387410

   Could we get a test or two for this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Modify decimal regex to accept positive exponent specifier [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5649:
URL: https://github.com/apache/arrow-rs/pull/5649#issuecomment-2058663962

   Thank you, looks good to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Modify decimal regex to accept positive exponent specifier [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5649:
URL: https://github.com/apache/arrow-rs/pull/5649


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Modify decimal regex to accept positive exponent specifier [arrow-rs]

Posted by "jdcasale (via GitHub)" <gi...@apache.org>.
jdcasale commented on PR #5649:
URL: https://github.com/apache/arrow-rs/pull/5649#issuecomment-2057606852

   @tustvold I've added a test asserting correctness of the result of inferring a schema on float data that includes scientific notation data. (with both positive and negative exponents) 
   
   I modeled it on adjacent tests so I don't think the test itself is likely to be controversial, but this is my first-time committing to this repository so please do let me know if there's anything else you'd like to see on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Modify decimal regex to accept positive exponent specifier [arrow-rs]

Posted by "jdcasale (via GitHub)" <gi...@apache.org>.
jdcasale commented on PR #5649:
URL: https://github.com/apache/arrow-rs/pull/5649#issuecomment-2057398230

   Sure -- will add a couple of tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org