You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/11/24 02:11:34 UTC

[GitHub] [orc] luffy-zh commented on a diff in pull request #1323: ORC-1315:[C++] Fix byte to integer conversions fail on platforms with unsigned char type

luffy-zh commented on code in PR #1323:
URL: https://github.com/apache/orc/pull/1323#discussion_r1030996352


##########
c++/src/ByteRLE.cc:
##########
@@ -354,7 +354,7 @@ namespace orc {
     if (bufferStart == bufferEnd) {
       nextBuffer();
     }
-    return *(bufferStart++);
+    return static_cast<signed char>(*(bufferStart++));

Review Comment:
   ByteRleDecoderImpl::readByte requires the signed char,  also see line 362.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org