You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2025/10/21 08:39:49 UTC
[PR] HTTPCLIENT-2403: Mutual authentication check not performed for proxies [httpcomponents-client]
stoty opened a new pull request, #745:
URL: https://github.com/apache/httpcomponents-client/pull/745
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCLIENT-2403: Mutual authentication check not performed for proxies [httpcomponents-client]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #745:
URL: https://github.com/apache/httpcomponents-client/pull/745#discussion_r2448086034
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/AuthenticationHandler.java:
##########
@@ -121,8 +121,7 @@ public boolean isChallenged(
}
/**
- * Determines whether the given response represents an authentication challenge, without
- * changing the {@link AuthExchange} state.
+ * Determines whether the response is 401/407 response depending to the challengeType
Review Comment:
Sure, I reverted to the original wording, but added a reference to challangeType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCLIENT-2403: Mutual authentication check not performed for proxies [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #745:
URL: https://github.com/apache/httpcomponents-client/pull/745#issuecomment-3427633284
@stoty Cherry-picked to `5.5.x`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCLIENT-2403: Mutual authentication check not performed for proxies [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on code in PR #745:
URL: https://github.com/apache/httpcomponents-client/pull/745#discussion_r2447451847
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/AuthenticationHandler.java:
##########
@@ -121,8 +121,7 @@ public boolean isChallenged(
}
/**
- * Determines whether the given response represents an authentication challenge, without
- * changing the {@link AuthExchange} state.
+ * Determines whether the response is 401/407 response depending to the challengeType
Review Comment:
@stoty Can we avoid using explicit status codes here and use a more generic "challenge" term?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCLIENT-2403: Mutual authentication check not performed for proxies [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c merged PR #745:
URL: https://github.com/apache/httpcomponents-client/pull/745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org