You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/27 17:14:04 UTC
[GitHub] [shardingsphere] ntsompa opened a new pull request #16418: Add unit test for GlobalLockNode.generateSchemaLockName in GlobalLock…
ntsompa opened a new pull request #16418:
URL: https://github.com/apache/shardingsphere/pull/16418
…NodeTest class
Fixes #16391.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16418: Add unit test for GlobalLockNode.generateSchemaLockName in GlobalLock…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16418:
URL: https://github.com/apache/shardingsphere/pull/16418#issuecomment-1080004791
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16418](https://codecov.io/gh/apache/shardingsphere/pull/16418?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc786f7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dec71051a276e34ba8391346c7eacb31a9022385?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dec7105) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16418 +/- ##
=========================================
Coverage 60.77% 60.77%
Complexity 2089 2089
=========================================
Files 3319 3319
Lines 50176 50176
Branches 8598 8598
=========================================
+ Hits 30494 30495 +1
+ Misses 17137 17136 -1
Partials 2545 2545
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...oordinator/future/lock/service/GlobalLockNode.java](https://codecov.io/gh/apache/shardingsphere/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9mdXR1cmUvbG9jay9zZXJ2aWNlL0dsb2JhbExvY2tOb2RlLmphdmE=) | `70.00% <0.00%> (+10.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16418?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16418?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dec7105...bc786f7](https://codecov.io/gh/apache/shardingsphere/pull/16418?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on pull request #16418: Add unit test for GlobalLockNode.generateSchemaLockName in GlobalLock…
Posted by GitBox <gi...@apache.org>.
zjcnb commented on pull request #16418:
URL: https://github.com/apache/shardingsphere/pull/16418#issuecomment-1080110757
> Hello, what do i need to do now, in order for my commit to be merged? Thank you.
It has conflicts, Resolve it please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ntsompa commented on pull request #16418: Add unit test for GlobalLockNode.generateSchemaLockName in GlobalLock…
Posted by GitBox <gi...@apache.org>.
ntsompa commented on pull request #16418:
URL: https://github.com/apache/shardingsphere/pull/16418#issuecomment-1080013950
Hello, what do i need to do now, in order for my commit to be merged? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #16418: Add unit test for GlobalLockNode.generateSchemaLockName in GlobalLock…
Posted by GitBox <gi...@apache.org>.
zjcnb merged pull request #16418:
URL: https://github.com/apache/shardingsphere/pull/16418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ntsompa commented on pull request #16418: Add unit test for GlobalLockNode.generateSchemaLockName in GlobalLock…
Posted by GitBox <gi...@apache.org>.
ntsompa commented on pull request #16418:
URL: https://github.com/apache/shardingsphere/pull/16418#issuecomment-1080995416
@zjcnb I think i resolved the conflict. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on pull request #16418: Add unit test for GlobalLockNode.generateSchemaLockName in GlobalLock…
Posted by GitBox <gi...@apache.org>.
totalo commented on pull request #16418:
URL: https://github.com/apache/shardingsphere/pull/16418#issuecomment-1080091248
> Hello, what do i need to do now, in order for my commit to be merged? Thank you.
hi @ntsompa , Thanks for your nice work, we need to wait for ci to pass and we can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org