You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/12/05 16:02:12 UTC
Re: Review Request 64012: Added new `--reconfiguration_policy` slave
flag and implementation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64012/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 4:02 p.m.)
Review request for mesos and Vinod Kone.
Summary (updated)
-----------------
Added new `--reconfiguration_policy` slave flag and implementation.
Repository: mesos
Description (updated)
-------
This flag allows operators to select a set of permitted
configuration changes that the slave will tolerate during
recovery while still recovering running tasks and keeping
the same agent id.
The previous behaviour of Mesos is reproduced exactly by setting
this flag to "equal". For now only one additional policy is
provided, "additive".
Diffs (updated)
-----
src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88
src/Makefile.am 08d29ab58fe5c7f5e0c9173b504787ec254ed99b
src/slave/compatibility.hpp PRE-CREATION
src/slave/compatibility.cpp PRE-CREATION
src/slave/flags.hpp f25d8aff29d0698eaf06dd40a86a35e43bc9e094
src/slave/flags.cpp 34edf4cb4a1afc366e6b6b4ddf78e90e49853fdf
src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059
src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc
src/tests/CMakeLists.txt 5e5202079c9798b91028e845490b747d4d1d0a66
src/tests/master_tests.cpp 08742ec878b29ef275fb40e857efffcf4c2f9ac2
src/tests/slave_compatibility_tests.cpp PRE-CREATION
src/tests/slave_recovery_tests.cpp 7674e607ee5bb7efbceb81c3e7291bc558d69935
src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb
Diff: https://reviews.apache.org/r/64012/diff/7/
Changes: https://reviews.apache.org/r/64012/diff/6-7/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64012: Added new `--reconfiguration_policy` slave
flag and implementation.
Posted by Vinod Kone <vi...@apache.org>.
> On Dec. 5, 2017, 8:18 p.m., Vinod Kone wrote:
> > src/slave/compatibility.hpp
> > Lines 33-36 (original), 32-41 (patched)
> > <https://reviews.apache.org/r/64012/diff/6-7/?file=1908031#file1908031line33>
> >
> > Instead of specifying each field here, since it can go out of date, why not just say every field in `SlaveInfo` because that's what you are essentially doing?
I'll fix this while committing.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64012/#review192913
-----------------------------------------------------------
On Dec. 5, 2017, 4:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64012/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 4:02 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows operators to select a set of permitted
> configuration changes that the slave will tolerate during
> recovery while still recovering running tasks and keeping
> the same agent id.
>
> The previous behaviour of Mesos is reproduced exactly by setting
> this flag to "equal". For now only one additional policy is
> provided, "additive".
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88
> src/Makefile.am 08d29ab58fe5c7f5e0c9173b504787ec254ed99b
> src/slave/compatibility.hpp PRE-CREATION
> src/slave/compatibility.cpp PRE-CREATION
> src/slave/flags.hpp f25d8aff29d0698eaf06dd40a86a35e43bc9e094
> src/slave/flags.cpp 34edf4cb4a1afc366e6b6b4ddf78e90e49853fdf
> src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059
> src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc
> src/tests/CMakeLists.txt 5e5202079c9798b91028e845490b747d4d1d0a66
> src/tests/master_tests.cpp 08742ec878b29ef275fb40e857efffcf4c2f9ac2
> src/tests/slave_compatibility_tests.cpp PRE-CREATION
> src/tests/slave_recovery_tests.cpp 7674e607ee5bb7efbceb81c3e7291bc558d69935
> src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb
>
>
> Diff: https://reviews.apache.org/r/64012/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64012: Added new `--reconfiguration_policy` slave
flag and implementation.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64012/#review192913
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/compatibility.hpp
Lines 33-36 (original), 32-41 (patched)
<https://reviews.apache.org/r/64012/#comment271257>
Instead of specifying each field here, since it can go out of date, why not just say every field in `SlaveInfo` because that's what you are essentially doing?
- Vinod Kone
On Dec. 5, 2017, 4:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64012/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 4:02 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag allows operators to select a set of permitted
> configuration changes that the slave will tolerate during
> recovery while still recovering running tasks and keeping
> the same agent id.
>
> The previous behaviour of Mesos is reproduced exactly by setting
> this flag to "equal". For now only one additional policy is
> provided, "additive".
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88
> src/Makefile.am 08d29ab58fe5c7f5e0c9173b504787ec254ed99b
> src/slave/compatibility.hpp PRE-CREATION
> src/slave/compatibility.cpp PRE-CREATION
> src/slave/flags.hpp f25d8aff29d0698eaf06dd40a86a35e43bc9e094
> src/slave/flags.cpp 34edf4cb4a1afc366e6b6b4ddf78e90e49853fdf
> src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059
> src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc
> src/tests/CMakeLists.txt 5e5202079c9798b91028e845490b747d4d1d0a66
> src/tests/master_tests.cpp 08742ec878b29ef275fb40e857efffcf4c2f9ac2
> src/tests/slave_compatibility_tests.cpp PRE-CREATION
> src/tests/slave_recovery_tests.cpp 7674e607ee5bb7efbceb81c3e7291bc558d69935
> src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb
>
>
> Diff: https://reviews.apache.org/r/64012/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>