[GitHub] [incubator-superset] mistercrunch opened a new pull request #8087: fix: minor release/license related issues

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #8087: fix: minor release/license related issues
URL: https://github.com/apache/incubator-superset/pull/8087
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [x] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Addressing issues that surfaced while voting on the 0.34.0rc1 release. Justin McLean's feedback:
   ```
   LiCENSE is missing:
   - This BSD licensed file [1] The file also has an incorrectly has an ASF header on it.
   - This file in not mentioned [2] and I think is licensed like so [3] If so that may be problematic [4]. However I seem to recall this was discussed before so there may of been some conclusion about it? I also note that .*geojson are explicitly listed in your rat excludes so I assume there a reason for that. (Comments in the rat exclusion file could help here).
   - This file [5] looks to contain the Monokai theme from [6] I’m unsure how this is licensed. The pro version seems to require a commercial license. It might of come from here [7]? which is MIT licensed.
   
   Thanks,
   Justin
   
   1. ./superset/extract_table_names.py
   2 ./assets/src/visualizations/CountryMap/countries/india.geojson
   3. ./licenses/LICENSE-diva-gis.txt
   4. https://apache.org/legal/resolved.html#cc-by
   5. superset/assets/src/components/FilterableTable/FilterableTable.jsx
   6. https://www.monokai.nl
   7 https://packagecontrol.io/packages/Monokai%20JSON%2B
   8 https://incubator.apache.org/policy/incubation.html#disclaimers
   ```
   
   This PR addresses:
   1-unused file
   2-unused, probably a merge conflict of sorts, file belongs in another repo, here: `superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-country-map/src/countries/`
   3-diva also lives in the `superset-ui-plugins` repo now, not needed
   
   Other issues have yet to be resolved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org