You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "soumitra-st (via GitHub)" <gi...@apache.org> on 2023/10/06 13:43:16 UTC
[PR] Upgrading Apache Helix to 1.3.1 version [pinot]
soumitra-st opened a new pull request, #11754:
URL: https://github.com/apache/pinot/pull/11754
This PR is a followup to https://github.com/apache/pinot/pull/11450, which was reverted because of an Helix issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11754:
URL: https://github.com/apache/pinot/pull/11754#discussion_r1349770634
##########
LICENSE-binary:
##########
@@ -404,11 +404,11 @@ org.apache.flink:flink-shaded-netty:4.1.49.Final-12.0
org.apache.flink:flink-shaded-zookeeper-3:3.4.14-12.0
org.apache.flink:flink-streaming-java_2.12:1.12.0
org.apache.flink:force-shading:1.12.0
-org.apache.helix:helix-common:1.0.4
-org.apache.helix:helix-core:1.0.4
-org.apache.helix:metadata-store-directory-common:1.0.4
-org.apache.helix:metrics-common:1.0.4
-org.apache.helix:zookeeper-api:1.0.4
+org.apache.helix:helix-core:1.3.1
Review Comment:
```suggestion
org.apache.helix:helix-common:1.3.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #11754:
URL: https://github.com/apache/pinot/pull/11754#issuecomment-1751157401
Please also upgrade the license, see #11560 for reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on code in PR #11754:
URL: https://github.com/apache/pinot/pull/11754#discussion_r1349705529
##########
LICENSE-binary:
##########
@@ -404,8 +404,7 @@ org.apache.flink:flink-shaded-netty:4.1.49.Final-12.0
org.apache.flink:flink-shaded-zookeeper-3:3.4.14-12.0
org.apache.flink:flink-streaming-java_2.12:1.12.0
org.apache.flink:force-shading:1.12.0
-org.apache.helix:helix-common:1.0.4
Review Comment:
I thought only direct dependencies are listed in the LICENSE file. Brought back the helix-common and fixed license in the rest of helix libs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11754:
URL: https://github.com/apache/pinot/pull/11754#discussion_r1349633008
##########
LICENSE-binary:
##########
@@ -404,8 +404,7 @@ org.apache.flink:flink-shaded-netty:4.1.49.Final-12.0
org.apache.flink:flink-shaded-zookeeper-3:3.4.14-12.0
org.apache.flink:flink-streaming-java_2.12:1.12.0
org.apache.flink:force-shading:1.12.0
-org.apache.helix:helix-common:1.0.4
Review Comment:
Are you sure? helix-common is pulled by helix-core. You are missing the following 3 lines as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11754:
URL: https://github.com/apache/pinot/pull/11754#issuecomment-1750783213
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11754](https://app.codecov.io/gh/apache/pinot/pull/11754?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (820fb38) into [master](https://app.codecov.io/gh/apache/pinot/commit/13c2901978c7a6a7bab46afbce2b09c13a0b05e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (13c2901) will **decrease** coverage by `48.73%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11754 +/- ##
=============================================
- Coverage 63.13% 14.41% -48.73%
+ Complexity 1117 201 -916
=============================================
Files 2342 2342
Lines 125916 125914 -2
Branches 19370 19370
=============================================
- Hits 79501 18151 -61350
- Misses 40749 106228 +65479
+ Partials 5666 1535 -4131
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-17](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-20](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.41% <ø> (-48.57%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.41% <ø> (-48.73%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.41% <ø> (-48.72%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/11754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.41% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1515 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11754/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on code in PR #11754:
URL: https://github.com/apache/pinot/pull/11754#discussion_r1349610544
##########
LICENSE-binary:
##########
@@ -404,8 +404,7 @@ org.apache.flink:flink-shaded-netty:4.1.49.Final-12.0
org.apache.flink:flink-shaded-zookeeper-3:3.4.14-12.0
org.apache.flink:flink-streaming-java_2.12:1.12.0
org.apache.flink:force-shading:1.12.0
-org.apache.helix:helix-common:1.0.4
Review Comment:
helix-common is not used, so removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11754:
URL: https://github.com/apache/pinot/pull/11754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org