You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/02/01 19:01:23 UTC
Review Request 65461: Provide new overload of 'ProcessBase::route()'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Repository: mesos
Description
-------
Provide new overload of 'ProcessBase::route()'.
Diffs
-----
3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
Diff: https://reviews.apache.org/r/65461/diff/1/
Testing
-------
It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
Thanks,
Benno Evers
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Benno Evers <be...@mesosphere.com>.
> On Feb. 3, 2018, 12:06 a.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/include/process/process.hpp
> > Lines 325-352 (original), 325-352 (patched)
> > <https://reviews.apache.org/r/65461/diff/1/?file=1951302#file1951302line325>
> >
> > These look obviated by your new one? Why do we still need these?
The overload taking an `AuthenticatedHttpRequestHandler` is still required when we pass a lambda to `route()`, e.g. from `master.cpp`. I've removed the other one.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review196764
-----------------------------------------------------------
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/2/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review196764
-----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp
Lines 325-352 (original), 325-352 (patched)
<https://reviews.apache.org/r/65461/#comment276605>
These look obviated by your new one? Why do we still need these?
- Benjamin Mahler
On Feb. 1, 2018, 7:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2018, 7:01 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/1/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198028
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197863
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197943
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197984
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198016
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197903
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 7:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 7:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198020
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197975
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197859
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197877
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198036
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 6:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 6:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review201096
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Feb. 28, 2018, 7:55 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 7:55 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp 3a5bd3dfafa7d4adec26d17acad3e4f27e4046ea
>
>
> Diff: https://reviews.apache.org/r/65461/diff/4/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provided new overload of
'ProcessBase::route()'.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/
-----------------------------------------------------------
(Updated Feb. 28, 2018, 7:55 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Summary (updated)
-----------------
Provided new overload of 'ProcessBase::route()'.
Repository: mesos
Description (updated)
-------
Provided new overload of 'ProcessBase::route()'.
Diffs
-----
3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
Diff: https://reviews.apache.org/r/65461/diff/3/
Testing
-------
It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
Thanks,
Benno Evers
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197915
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197959
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197927
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197867
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198002
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198059
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197887
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197895
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
> On Feb. 21, 2018, 9:31 p.m., Mesos Reviewbot Windows wrote:
> > Bad review!
> >
> > Error:
> > Circular dependency detected for review 65462. Please fix the 'depends_on' field.
There was a glitch in the reviewbot code. This was fixed. Sorry for the spam!
- Mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198063
-----------------------------------------------------------
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198063
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198050
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197873
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197964
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197937
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197947
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197968
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197988
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198012
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197980
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198055
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197955
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197919
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197951
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198024
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198032
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197881
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197931
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197996
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198045
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197854
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review197891
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198006
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/#review198041
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 65462. Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Feb. 6, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65461/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Provide new overload of 'ProcessBase::route()'.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
> 3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
> 3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
> 3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
>
>
> Diff: https://reviews.apache.org/r/65461/diff/3/
>
>
> Testing
> -------
>
> It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
>
> This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 65461: Provide new overload of
'ProcessBase::route()'.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/
-----------------------------------------------------------
(Updated Feb. 6, 2018, 5:40 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Repository: mesos
Description
-------
Provide new overload of 'ProcessBase::route()'.
Diffs (updated)
-----
3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5
3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f
3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0
3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf
Diff: https://reviews.apache.org/r/65461/diff/2/
Changes: https://reviews.apache.org/r/65461/diff/1-2/
Testing
-------
It is a common pattern in libprocess to have a single function serving as endpoint that handles both authenticated and non-authenticated requests, providing `None()` as a default parameter in non-authenticated contexts.
This patch adds an overload to `ProcessBase::route()` implementing that so that it does not need to be re-implemented in each individual process.
Thanks,
Benno Evers