[jira] Updated: (WICKET-1953) isEnabled called even if component is not Visible

["Jim Larsen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Larsen updated WICKET-1953:
-------------------------------

    Description: 
in the Form class i came across this code (not by accident thow :-))

if (component.isEnabled() && component.isEnableAllowed() &&
    component.isVisibleInHierarchy())
{
        ((IFormModelUpdateListener)component).updateModel();
}

The result of this is that isEnabled is called on components that is not even visible
I would like this changed to:

if (component.isVisibleInHierarchy() &&
    component.isEnabled() && component.isEnableAllowed())
{
        ((IFormModelUpdateListener)component).updateModel();
}






  was:
in the Form class i came across this code

if (component.isEnabled() && component.isEnableAllowed() &&
    component.isVisibleInHierarchy())
{
        ((IFormModelUpdateListener)component).updateModel();
}

Thee result of this is that isEnabled is called on components that is not even visible
I would like this changed to:

if (component.isVisibleInHierarchy() &&
    component.isEnabled() && component.isEnableAllowed())
{
        ((IFormModelUpdateListener)component).updateModel();
}







> isEnabled called even if component is not Visible
> -------------------------------------------------
>
>                 Key: WICKET-1953
>                 URL: https://issues.apache.org/jira/browse/WICKET-1953
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-RC1
>            Reporter: Jim Larsen
>
> in the Form class i came across this code (not by accident thow :-))
> if (component.isEnabled() && component.isEnableAllowed() &&
>     component.isVisibleInHierarchy())
> {
>         ((IFormModelUpdateListener)component).updateModel();
> }
> The result of this is that isEnabled is called on components that is not even visible
> I would like this changed to:
> if (component.isVisibleInHierarchy() &&
>     component.isEnabled() && component.isEnableAllowed())
> {
>         ((IFormModelUpdateListener)component).updateModel();
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.