You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2025/10/15 17:48:58 UTC
[PR] [SPARK-53923][CORE] Rename `spark.executor.(log -> logs).redirectConsoleOutputs` [spark]
dongjoon-hyun opened a new pull request, #52624:
URL: https://github.com/apache/spark/pull/52624
## What changes were proposed in this pull request?
This PR aims to rename `spark.executor.log.redirectConsoleOutputs` to ``spark.executor.logs.redirectConsoleOutputs` to be consistent with the existing executor log configurations.
```
spark.executor.logs.rolling.strategy
spark.executor.logs.rolling.time.interval
spark.executor.logs.rolling.maxSize
spark.executor.logs.rolling.maxRetainedFiles
spark.executor.logs.rolling.enableCompression
spark.executor.logs.redirectConsoleOutputs
```
### Why are the changes needed?
Although SPARK-52426 introduced two configurations consistently in the PR, Apache Spark has different namespace for Driver and Executor which are `spark.driver.log.*` and `spark.executor.logs.*` respectively. Instead of introducing a new config namespace, `spark.executor.log`, for this single new configuration, we had better follow the existing naming rule.
- https://github.com/apache/spark/pull/51130
```
spark.driver.log.redirectConsoleOutputs
spark.executor.log.redirectConsoleOutputs
```
### Does this PR introduce _any_ user-facing change?
No this is not released yet.
### How was this patch tested?
Pass the CIs. Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53923][CORE] Rename `spark.executor.(log -> logs).redirectConsoleOutputs` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #52624:
URL: https://github.com/apache/spark/pull/52624#issuecomment-3407618604
Thank you, @peter-toth .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53923][CORE] Rename `spark.executor.(log -> logs).redirectConsoleOutputs` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #52624:
URL: https://github.com/apache/spark/pull/52624#issuecomment-3407607623
cc @pan3793 , @yaooqinn , @peter-toth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53923][CORE] Rename `spark.executor.(log -> logs).redirectConsoleOutputs` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #52624:
URL: https://github.com/apache/spark/pull/52624#issuecomment-3407840051
Merged to master for Apache Spark 4.1.0-preview3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53923][CORE] Rename `spark.executor.(log -> logs).redirectConsoleOutputs` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #52624:
URL: https://github.com/apache/spark/pull/52624#issuecomment-3407808837
Thank you, @pan3793 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53923][CORE] Rename `spark.executor.(log -> logs).redirectConsoleOutputs` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #52624: [SPARK-53923][CORE] Rename `spark.executor.(log -> logs).redirectConsoleOutputs`
URL: https://github.com/apache/spark/pull/52624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org