You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "dipsk2 (via GitHub)" <gi...@apache.org> on 2023/10/09 13:10:20 UTC
[PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
dipsk2 opened a new pull request, #1465:
URL: https://github.com/apache/cxf/pull/1465
With OTel, it is required for every span must be closed by the one who started it.
Added a condition in the OutInterceptor to close the span immediately if it is a one-way call since InInterceptor will never be invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "dipsk2 (via GitHub)" <gi...@apache.org>.
dipsk2 closed pull request #1465: OpenTelemetry: OneWay client calls not closing the span
URL: https://github.com/apache/cxf/pull/1465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "dipsk2 (via GitHub)" <gi...@apache.org>.
dipsk2 commented on PR #1465:
URL: https://github.com/apache/cxf/pull/1465#issuecomment-1759834497
@reta
I have created a small project here: https://github.com/dipsk2/cxf-client-otel-bug to help explain the issue.
There is a test (https://github.com/dipsk2/cxf-client-otel-bug/blob/main/src/test/java/org/example/cxfclientotelbug/CxfClientOtelBugApplicationTests.java) that can be executed to see the behaviour of one-way vs two-way calls.
The test also has comments explaining the observations.
Please have a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "dipsk2 (via GitHub)" <gi...@apache.org>.
dipsk2 commented on PR #1465:
URL: https://github.com/apache/cxf/pull/1465#issuecomment-1764101938
Yes I thought so too, but this was the easiest solution I could think of - based on my limited knowledge of cxf itself.
Thanks for confirming the issue and looking forward to the fix. We are waiting for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #1465:
URL: https://github.com/apache/cxf/pull/1465#issuecomment-1758688304
@dipsk2 I was trying to reproduce the issue but no luck, could you please provide the test case or at least reproducer to it, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #1465:
URL: https://github.com/apache/cxf/pull/1465#discussion_r1355104727
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -37,6 +27,15 @@
import io.opentelemetry.context.Context;
import io.opentelemetry.context.Scope;
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
+import org.apache.cxf.common.logging.LogUtils;
Review Comment:
@dipsk2 could you please revert import and formatting changes? thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "dipsk2 (via GitHub)" <gi...@apache.org>.
dipsk2 commented on code in PR #1465:
URL: https://github.com/apache/cxf/pull/1465#discussion_r1355326688
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -37,6 +27,15 @@
import io.opentelemetry.context.Context;
import io.opentelemetry.context.Scope;
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
+import org.apache.cxf.common.logging.LogUtils;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "dipsk2 (via GitHub)" <gi...@apache.org>.
dipsk2 commented on PR #1465:
URL: https://github.com/apache/cxf/pull/1465#issuecomment-1770952399
Closing this one in favor of #1472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #1465:
URL: https://github.com/apache/cxf/pull/1465#issuecomment-1765477959
> Yes I thought so too, but this was the easiest solution I could think of - based on my limited knowledge of cxf itself. Thanks for confirming the issue and looking forward to the fix. We are waiting for it.
:+1, here we are https://github.com/apache/cxf/pull/1472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #1465:
URL: https://github.com/apache/cxf/pull/1465#discussion_r1355340094
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryClientProvider.java:
##########
@@ -37,6 +27,15 @@
import io.opentelemetry.context.Context;
import io.opentelemetry.context.Scope;
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
+import org.apache.cxf.common.logging.LogUtils;
Review Comment:
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OpenTelemetry: OneWay client calls not closing the span [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #1465:
URL: https://github.com/apache/cxf/pull/1465#issuecomment-1763144714
> @reta
> I have created a small project here: https://github.com/dipsk2/cxf-client-otel-bug to help explain the issue.
Thanks a lot @dipsk2 , I think I could confidently confirm that there is an issue with out interceptors and one-way messages, the solution you are suggesting would address one particular case however I believe we need more robust approach in CXF to handle this particular invocation scenario. I will try to have some options drafted shortly. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org