[GitHub] [airflow] potiuk commented on a diff in pull request #28638: Fix for LocalKubernetesExecutor scheduler is not serving logs

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #28638:
URL: https://github.com/apache/airflow/pull/28638#discussion_r1059097979


##########
chart/templates/scheduler/scheduler-service.yaml:
##########
@@ -18,7 +18,7 @@
 ################################
 ## Airflow Scheduler Service
 #################################
-{{- if eq .Values.executor "LocalExecutor" }}
+{{- if or (eq .Values.executor "LocalExecutor") (eq .Values.executor "LocalKubernetesExecutor")}}

Review Comment:
   I think if we want to make our Chart fully compatible with AIP-51 and allow "any" executors we should also implement some way to override Helm Chart behaviour for custom executors. But we can do it later. CC: @o-nikolas 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org