You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/26 10:22:34 UTC

[GitHub] [flink] Myracle commented on a change in pull request #12958: [FLINK-18625][runtime] Maintain redundant taskmanagers to speed up failover

Myracle commented on a change in pull request #12958:
URL: https://github.com/apache/flink/pull/12958#discussion_r460508614



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImplTest.java
##########
@@ -976,6 +976,7 @@ public void testTaskManagerTimeoutDoesNotRemoveSlots() throws Exception {
 
 		try (final SlotManager slotManager = createSlotManagerBuilder()
 			.setTaskManagerTimeout(taskManagerTimeout)
+			.setRedundantSlotNum(0)

Review comment:
       If default value is changed for certain organization or special situation, developers need to fix this test. Unit test should be run in any valid config. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org