Re: [PR] HDDS-9683. Containers present on decommission nodes are reported as mis-replicated [ozone]

["xBis7 (via GitHub)" <gi...@apache.org>]

xBis7 commented on code in PR #5726:
URL: https://github.com/apache/ozone/pull/5726#discussion_r1423820378


##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java:
##########
@@ -563,6 +574,69 @@ public void testvalidateContainerPlacementSingleRackCluster() {
     assertEquals(0, stat.misReplicationCount());
   }
 
+  @ParameterizedTest
+  @MethodSource("decommissionNodeStates")

Review Comment:
   > (MethodSource allows any collection (does not have to use Stream), and for single parameter we can use the type directly, no need to wrap i nArguments.)
   
   Thanks @adoroszlai for the info. I didn't know that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org