You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/18 14:56:57 UTC

[GitHub] [ignite] samaitra commented on a change in pull request #8041: IGNITE-13259 Removed default cache from REST APIs

samaitra commented on a change in pull request #8041:
URL: https://github.com/apache/ignite/pull/8041#discussion_r456797662



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/handlers/GridRestCommandHandlerAdapter.java
##########
@@ -26,8 +26,6 @@
  * Abstract command handler.
  */
 public abstract class GridRestCommandHandlerAdapter implements GridRestCommandHandler {
-    /** Used cache name in case the name was not defined in a request. */
-    protected static final String DFLT_CACHE_NAME = "default";

Review comment:
       The default cacheName is safe fallback when cache name is not provided in the request. It is part of rest document.
   
   https://apacheignite.readme.io/docs/rest-api#put
   
   When request do not have cacheName since it is optional param then this DFLT_CACHE_NAME is used https://github.com/apache/ignite/pull/8041/files#diff-a3477d5e0cfdfcceed3371fc899a9d15L30




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org