You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/01 03:31:05 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #8755: [bot-cherry-pick]Fix reader always has message available

codelipenghui opened a new pull request #8755:
URL: https://github.com/apache/pulsar/pull/8755


   Fixes #8721
   
   ### Motivation
   Whenever you create a new Reader with startMessageId set to latest and startMessageIdInclusive, hasMessageAvailable will be always true even if the topic is freshly created without any messages inside. If you remove message inclusiveness, then the issue is not appearing.
   
   ### Modifications
   If the returned entryId is illegal, it means there is no message
   
   ### Verifying this change
   ReaderTest#testReaderHasMessageAvailable
   
   (cherry picked from commit 4d8974d8581af53b386dd1d58edca42250e377fe)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #8755: [bot-cherry-pick]Fix reader always has message available

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8755:
URL: https://github.com/apache/pulsar/pull/8755#issuecomment-737152197


   Hey. If you want to cherry-pick this pr to a target branch, please comments '/pulsarbot cherry-pick to branch-x.y'.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #8755: [bot-cherry-pick]Fix reader always has message available

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8755:
URL: https://github.com/apache/pulsar/pull/8755


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org