[jira] [Commented] (GROOVY-7810) XmlSluper default constructor documentation about namespace aware incorrect.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227052#comment-15227052 ] 

ASF GitHub Bot commented on GROOVY-7810:
----------------------------------------

GitHub user gillius opened a pull request:

    https://github.com/apache/groovy/pull/305

    GROOVY-7810 fix XmlSlurper default ctor doc

    Javadoc for default constructor says it creates a non-namespace-aware slurper, when it creates a namespace-aware one.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gillius/incubator-groovy patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #305
    
----
commit 0d3e0cffe45978fab0d296b518d23574a474cb88
Author: Jason Winnebeck <gi...@gillius.org>
Date:   2016-04-05T20:11:31Z

    GROOVY-7810 fix XmlSlurper default ctor doc
    
    Javadoc for default constructor says it creates a non-namespace-aware slurper, when it creates a namespace-aware one.

----


> XmlSluper default constructor documentation about namespace aware incorrect.
> ----------------------------------------------------------------------------
>
>                 Key: GROOVY-7810
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7810
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.6
>            Reporter: Jason Winnebeck
>
> Here is the current implementation of XmlSlurper's default constructor as of 2.4.6:
> {code}
>     /**
>      * Creates a non-validating and non-namespace-aware <code>XmlSlurper</code> which does not allow DOCTYPE declarations in documents.
>      *
>      * @throws ParserConfigurationException if no parser which satisfies the requested configuration can be created.
>      * @throws SAXException for SAX errors.
>      */
>     public XmlSlurper() throws ParserConfigurationException, SAXException {
>         this(false, true);
>     }
> {code}
> It clearly creates a namespace-aware slurper.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)