[GitHub] [fineract] vorburger commented on a change in pull request #1597: Add condition to start TLS (FINERACT-1070)

[GitBox <gi...@apache.org>]

vorburger commented on a change in pull request #1597:
URL: https://github.com/apache/fineract/pull/1597#discussion_r593768189



##########
File path: fineract-provider/dependencies.gradle
##########
@@ -80,7 +80,8 @@ dependencies {
             'org.webjars:webjars-locator-core',
 
             'com.google.cloud.sql:mysql-socket-factory-connector-j-8:1.2.1',
-            'com.squareup.retrofit2:converter-gson'
+            'com.squareup.retrofit2:converter-gson',
+            'com.sun.activation:jakarta.activation:1.2.2'

Review comment:
       @BLasan @ptuomola I've not looked closely here, but it seems to be that using             'com.sun.activation:jakarta.activation:1.2.2' is confusing, because it (probably, not verified) contains the exact same Java classes as the 'jakarta.activation' artifact... we should clean this up IMHO, but that could be done in a future PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org