You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-dev@logging.apache.org by ca...@apache.org on 2008/03/31 09:33:54 UTC

svn commit: r642910 - in /logging/log4cxx/trunk/src: changes/changes.xml main/cpp/socketoutputstream.cpp main/include/log4cxx/helpers/socketoutputstream.h

Author: carnold
Date: Mon Mar 31 00:33:52 2008
New Revision: 642910

URL: http://svn.apache.org/viewvc?rev=642910&view=rev
Log:
LOGCXX-259: Several appenders fail to compile with VC8

Modified:
    logging/log4cxx/trunk/src/changes/changes.xml
    logging/log4cxx/trunk/src/main/cpp/socketoutputstream.cpp
    logging/log4cxx/trunk/src/main/include/log4cxx/helpers/socketoutputstream.h

Modified: logging/log4cxx/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/changes/changes.xml?rev=642910&r1=642909&r2=642910&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/changes/changes.xml (original)
+++ logging/log4cxx/trunk/src/changes/changes.xml Mon Mar 31 00:33:52 2008
@@ -22,7 +22,7 @@
 <title>Apache log4cxx</title>
 </properties>
 <body>
-<release version="0.10.0" date="2008-04-02" description="First Apache release">
+<release version="0.10.0" date="2008-04-03" description="First Apache release">
 <action issue="LOGCXX-2">logger.h includes config.h</action>
 <action issue="LOGCXX-3">Missing #else</action>
 <action issue="LOGCXX-4">initialization not working on many OS's</action>
@@ -226,6 +226,7 @@
 <action issue="LOGCXX-256">SocketHubAppender fails after accepting connection</action>
 <action issue="LOGCXX-257">ServerSocket::accept hangs on Unix</action>
 <action issue="LOGCXX-258">unable to build from make dist package due to missing doxygen file</action>
+<action issue="LOGCXX-259">Several appenders fail to compile in Visual Studio 2008</action>
 </release>
 <release version="0.9.7" date="2004-05-10">
 <action type="fix">Fixed examples source code in the "Short introduction to log4cxx".</action>

Modified: logging/log4cxx/trunk/src/main/cpp/socketoutputstream.cpp
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/main/cpp/socketoutputstream.cpp?rev=642910&r1=642909&r2=642910&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/main/cpp/socketoutputstream.cpp (original)
+++ logging/log4cxx/trunk/src/main/cpp/socketoutputstream.cpp Mon Mar 31 00:33:52 2008
@@ -39,7 +39,7 @@
 
 void SocketOutputStream::flush(Pool& /* p */) {
    if (array.size() > 0) {
-     ByteBuffer buf(&array[0], array.size());
+     ByteBuffer buf((char*) &array[0], array.size());
      socket->write(buf);
      array.resize(0);
    }

Modified: logging/log4cxx/trunk/src/main/include/log4cxx/helpers/socketoutputstream.h
URL: http://svn.apache.org/viewvc/logging/log4cxx/trunk/src/main/include/log4cxx/helpers/socketoutputstream.h?rev=642910&r1=642909&r2=642910&view=diff
==============================================================================
--- logging/log4cxx/trunk/src/main/include/log4cxx/helpers/socketoutputstream.h (original)
+++ logging/log4cxx/trunk/src/main/include/log4cxx/helpers/socketoutputstream.h Mon Mar 31 00:33:52 2008
@@ -49,12 +49,10 @@
                         virtual void flush(Pool& p);
                         virtual void write(ByteBuffer& buf, Pool& p);
 
-                protected:
-                        LOG4CXX_LIST_DEF(ByteList, char);
+                private:
+                        LOG4CXX_LIST_DEF(ByteList, unsigned char);
                         ByteList array;
                         SocketPtr socket;
-
-                private:
                        //
                        //   prevent copy and assignment statements
                        SocketOutputStream(const SocketOutputStream&);