You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/05/06 13:26:49 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #30603: Support minAvailable property for PodDisruptionBudget

potiuk commented on code in PR #30603:
URL: https://github.com/apache/airflow/pull/30603#discussion_r1186697762


##########
chart/values.schema.json:
##########
@@ -1864,6 +1864,14 @@
                                         "string"
                                     ],
                                     "default": 1
+                                },
+                                "minAvailable": {
+                                    "description": "Min available pods for scheduler.",
+                                    "type": [
+                                        "integer",
+                                        "string"
+                                    ],
+                                    "default": 1

Review Comment:
   Yeah I think default has no real meaning in jsonSchema, other than aid the validation in case the value is not specified and we should be fine to use it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org