You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/01/04 18:49:55 UTC
[PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
voonhous opened a new pull request, #17781:
URL: https://github.com/apache/hudi/pull/17781
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the changes
(or) link to an issue by including `Closes #<issue-number>` for context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
Add Lombok Builders to:
1. HoodieFileGroupReader
2. InputSplit
3. ReaderParameters
This change removes boilerplate code and standardises builder patterns used.
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in behavior.
Followed by a detailed log of all the changes. Highlight if any code was copied. -->
Add Lombok Builders to:
1. HoodieFileGroupReader
2. InputSplit
3. ReaderParameters
Update usages and fixed compilation errors
### Impact
<!-- Describe any public API or user-facing feature change or any performance impact. -->
Improve developer experience.
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
If medium or high, explain what verification was done to mitigate the risks. -->
None
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
None
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308354940
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.09%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.09% +0.81%
- Complexity 18532 22458 +3926
============================================
Files 1944 2020 +76
Lines 106132 127403 +21271
Branches 13118 17687 +4569
============================================
+ Hits 60797 74018 +13221
- Misses 39612 46881 +7269
- Partials 5723 6504 +781
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.48% <83.33%> (-0.94%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.56% <72.00%> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [494 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308501641
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.63%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.63% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103526 +42729
+ Misses 39612 39260 -352
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.79% <84.00%> (+3.36%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943806041
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.33333%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.27%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 57.27% -0.02%
- Complexity 18532 18533 +1
============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
============================================
- Hits 60797 60775 -22
- Misses 39612 39619 +7
+ Partials 5723 5720 -3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.39% <83.33%> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <72.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.18% <100.00%> (+0.07%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.37% <100.00%> (+0.03%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599419063
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.80%
- Complexity 28461 29163 +702
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96373 +2523
+ Misses 38529 35887 -2642
- Partials 7667 7772 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.29% <84.00%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <72.00%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599713610
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
}, {
"hash" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209",
"triggerID" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"triggerType" : "PUSH"
}, {
"hash" : "5517d5a617927e8fb2afba4619cf814813fe1dca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14405",
"triggerID" : "5517d5a617927e8fb2afba4619cf814813fe1dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5517d5a617927e8fb2afba4619cf814813fe1dca Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #17781:
URL: https://github.com/apache/hudi/pull/17781#discussion_r2785082677
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -81,25 +85,113 @@ public final class HoodieFileGroupReader<T> implements Closeable {
private HoodieFileGroupRecordBuffer<T> recordBuffer;
private ClosableIterator<T> baseFileIterator;
private final Option<UnaryOperator<T>> outputConverter;
+ @Getter
private final HoodieReadStats readStats;
// Callback to run custom logic on updates to the base files for the file group
private final Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback;
// The list of instant times read from the log blocks, this value is used by the log-compaction to allow optimized log-block scans
+ @Getter
private List<String> validBlockInstants = Collections.emptyList();
private BufferedRecordConverter<T> bufferedRecordConverter;
- private HoodieFileGroupReader(HoodieReaderContext<T> readerContext, HoodieStorage storage, String tablePath,
- String latestCommitTime, HoodieSchema dataSchema, HoodieSchema requestedSchema,
- Option<InternalSchema> internalSchemaOpt, HoodieTableMetaClient hoodieTableMetaClient, TypedProperties props,
- ReaderParameters readerParameters, InputSplit inputSplit, Option<BaseFileUpdateCallback<T>> updateCallback,
- FileGroupRecordBufferLoader<T> recordBufferLoader) {
+ @Builder(setterPrefix = "with")
+ private HoodieFileGroupReader(
+ HoodieReaderContext<T> readerContext,
+ String latestCommitTime,
+ HoodieSchema dataSchema,
+ HoodieSchema requestedSchema,
+ Option<InternalSchema> internalSchemaOpt,
+ HoodieTableMetaClient hoodieTableMetaClient,
+ TypedProperties props,
+ Option<HoodieBaseFile> baseFileOption,
+ Stream<HoodieLogFile> logFiles,
+ String partitionPath,
+ Long start,
+ Long length,
+ Iterator<? extends HoodieRecord> recordIterator,
+ Boolean shouldUseRecordPosition,
+ Boolean allowInflightInstants,
+ Boolean emitDelete,
+ Boolean sortOutput,
+ Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback,
+ FileGroupRecordBufferLoader<T> recordBufferLoader) {
+
+ // Validations
+ ValidationUtils.checkArgument(readerContext != null, "Reader context is required");
+ ValidationUtils.checkArgument(hoodieTableMetaClient != null, "Hoodie table meta client is required");
+ ValidationUtils.checkArgument(latestCommitTime != null, "Latest commit time is required");
+ ValidationUtils.checkArgument(dataSchema != null, "Data schema is required");
+ ValidationUtils.checkArgument(requestedSchema != null, "Requested schema is required");
+ ValidationUtils.checkArgument(props != null, "Props is required");
+ ValidationUtils.checkArgument(partitionPath != null, "Partition path is required");
+
+ // Handle defaults
Review Comment:
Do you think we can use `Builder.Default` instead of null checking like below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599061542
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.38462%` with `45 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.86%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 44.86% -22.15%
+ Complexity 28461 8575 -19886
=============================================
Files 2520 1203 -1317
Lines 140046 62969 -77077
Branches 17197 6862 -10335
=============================================
- Hits 93850 28251 -65599
+ Misses 38529 31590 -6939
+ Partials 7667 3128 -4539
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `49.35% <100.00%> (-41.56%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `50.53% <100.00%> (-32.51%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `88.23% <100.00%> (-4.63%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `51.76% <100.00%> (-30.80%)` | :arrow_down: |
| [...hadoop/HoodieFileGroupReaderBasedRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieFileGroupReaderBasedRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUZpbGVHcm91cFJlYWRlckJhc2VkUmVjb3JkUmVhZGVyLmphdmE=) | `75.38% <100.00%> (-8.21%)` | :arrow_down: |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | `74.19% <50.00%> (-19.36%)` | :arrow_down: |
| ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2106 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #17781:
URL: https://github.com/apache/hudi/pull/17781#discussion_r3338870235
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -81,25 +85,113 @@ public final class HoodieFileGroupReader<T> implements Closeable {
private HoodieFileGroupRecordBuffer<T> recordBuffer;
private ClosableIterator<T> baseFileIterator;
private final Option<UnaryOperator<T>> outputConverter;
+ @Getter
private final HoodieReadStats readStats;
// Callback to run custom logic on updates to the base files for the file group
private final Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback;
// The list of instant times read from the log blocks, this value is used by the log-compaction to allow optimized log-block scans
+ @Getter
private List<String> validBlockInstants = Collections.emptyList();
private BufferedRecordConverter<T> bufferedRecordConverter;
- private HoodieFileGroupReader(HoodieReaderContext<T> readerContext, HoodieStorage storage, String tablePath,
- String latestCommitTime, HoodieSchema dataSchema, HoodieSchema requestedSchema,
- Option<InternalSchema> internalSchemaOpt, HoodieTableMetaClient hoodieTableMetaClient, TypedProperties props,
- ReaderParameters readerParameters, InputSplit inputSplit, Option<BaseFileUpdateCallback<T>> updateCallback,
- FileGroupRecordBufferLoader<T> recordBufferLoader) {
+ @Builder(setterPrefix = "with")
+ private HoodieFileGroupReader(
+ HoodieReaderContext<T> readerContext,
+ String latestCommitTime,
+ HoodieSchema dataSchema,
+ HoodieSchema requestedSchema,
+ Option<InternalSchema> internalSchemaOpt,
+ HoodieTableMetaClient hoodieTableMetaClient,
+ TypedProperties props,
+ Option<HoodieBaseFile> baseFileOption,
+ Stream<HoodieLogFile> logFiles,
+ String partitionPath,
+ Long start,
+ Long length,
+ Iterator<? extends HoodieRecord> recordIterator,
+ Boolean shouldUseRecordPosition,
+ Boolean allowInflightInstants,
+ Boolean emitDelete,
+ Boolean sortOutput,
+ Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback,
+ FileGroupRecordBufferLoader<T> recordBufferLoader) {
+
+ // Validations
+ ValidationUtils.checkArgument(readerContext != null, "Reader context is required");
+ ValidationUtils.checkArgument(hoodieTableMetaClient != null, "Hoodie table meta client is required");
+ ValidationUtils.checkArgument(latestCommitTime != null, "Latest commit time is required");
+ ValidationUtils.checkArgument(dataSchema != null, "Data schema is required");
+ ValidationUtils.checkArgument(requestedSchema != null, "Requested schema is required");
+ ValidationUtils.checkArgument(props != null, "Props is required");
+ ValidationUtils.checkArgument(partitionPath != null, "Partition path is required");
+
+ // Handle defaults
Review Comment:
Yeap, it's possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599249529
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.18%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|3|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 48.18% -18.84%
+ Complexity 28461 16554 -11907
=============================================
Files 2520 2024 -496
Lines 140046 113201 -26845
Branches 17197 14352 -2845
=============================================
- Hits 93850 54542 -39308
- Misses 38529 52924 +14395
+ Partials 7667 5735 -1932
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.11% <66.00%> (-17.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <64.00%> (-12.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.59% <100.00%> (-6.11%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.93% <100.00%> (-16.11%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `67.20% <100.00%> (-15.36%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1537 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599372954
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `85.53459%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.79%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 67.79% +0.77%
- Complexity 28461 28699 +238
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 94930 +1080
+ Misses 38529 37315 -1214
- Partials 7667 7787 +120
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <83.33%> (-4.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <72.00%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.02% <100.00%> (-0.68%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.53% <100.00%> (-7.51%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [281 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3708331931
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e40651d03ea05acd228032af487a58ba24d2e06 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308368003
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.36%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.36% +1.07%
- Complexity 18532 22599 +4067
============================================
Files 1944 2020 +76
Lines 106132 127403 +21271
Branches 13118 17687 +4569
============================================
+ Hits 60797 74357 +13560
- Misses 39612 46466 +6854
- Partials 5723 6580 +857
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.04% <83.33%> (-1.39%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.18% <72.00%> (-1.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943717403
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.66667%` with `20 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.24%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 55.24% -2.04%
+ Complexity 18532 17832 -700
============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
============================================
- Hits 60797 58623 -2174
- Misses 39612 41711 +2099
- Partials 5723 5780 +57
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.18% <82.66%> (-4.25%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.40% <72.00%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.81% <100.00%> (-0.30%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `74.76% <100.00%> (-6.59%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [266 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3708330759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e40651d03ea05acd228032af487a58ba24d2e06 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599378842
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.55%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.55% +1.53%
- Complexity 28461 29010 +549
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 95995 +2145
+ Misses 38529 36306 -2223
- Partials 7667 7731 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <84.00%> (-0.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <72.00%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [179 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308131777
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.33333%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.69%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 56.69% -0.59%
- Complexity 18532 20055 +1523
============================================
Files 1944 1969 +25
Lines 106132 116718 +10586
Branches 13118 14969 +1851
============================================
+ Hits 60797 66179 +5382
- Misses 39612 44398 +4786
- Partials 5723 6141 +418
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.42% <83.33%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <72.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.18% <100.00%> (+0.07%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `74.38% <100.00%> (-6.97%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308517200
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.79% <84.00%> (+3.36%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308356892
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.11%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.11% +0.83%
- Complexity 18532 22467 +3935
============================================
Files 1944 2020 +76
Lines 106132 127403 +21271
Branches 13118 17687 +4569
============================================
+ Hits 60797 74045 +13248
- Misses 39612 46852 +7240
- Partials 5723 6506 +783
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.25% <83.33%> (-1.17%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.56% <72.00%> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [494 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308313536
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.99%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 59.99% +2.71%
- Complexity 18532 21631 +3099
============================================
Files 1944 1972 +28
Lines 106132 117930 +11798
Branches 13118 15335 +2217
============================================
+ Hits 60797 70754 +9957
- Misses 39612 41071 +1459
- Partials 5723 6105 +382
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.42% <83.33%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <72.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `76.72% <100.00%> (-4.63%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [381 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943845868
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
}, {
"hash" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209",
"triggerID" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b396fdf3adeed2cb6672ec46fee918b8433e413a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4450093295
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 232 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.84% <84.00%> (+3.42%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4343151105
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 200 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.84% <84.00%> (+3.42%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308565076
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.84% <84.00%> (+3.42%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308459878
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.53%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 67.53% +10.24%
- Complexity 18532 30295 +11763
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 101857 +41060
- Misses 39612 41072 +1460
- Partials 5723 7897 +2174
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.81% <83.33%> (-1.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.44% <72.00%> (+0.93%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `85.46% <100.00%> (+4.12%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1391 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4494357083
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 270 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.84% <84.00%> (+3.42%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599029241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
}, {
"hash" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209",
"triggerID" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"triggerType" : "PUSH"
}, {
"hash" : "5517d5a617927e8fb2afba4619cf814813fe1dca",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14405",
"triggerID" : "5517d5a617927e8fb2afba4619cf814813fe1dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b396fdf3adeed2cb6672ec46fee918b8433e413a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209)
* 5517d5a617927e8fb2afba4619cf814813fe1dca Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14405)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599391571
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.73%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.73% +1.71%
- Complexity 28461 29109 +648
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96245 +2395
+ Misses 38529 36035 -2494
- Partials 7667 7752 +85
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.29% <84.00%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <72.00%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [148 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3708440116
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7afbdd6738ffb301e0cb760e39f578d4a360074b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599244521
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.18%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|3|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 48.18% -18.84%
+ Complexity 28461 16554 -11907
=============================================
Files 2520 2024 -496
Lines 140046 113201 -26845
Branches 17197 14352 -2845
=============================================
- Hits 93850 54542 -39308
- Misses 38529 52924 +14395
+ Partials 7667 5735 -1932
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.11% <66.00%> (-17.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <64.00%> (-12.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.59% <100.00%> (-6.11%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.93% <100.00%> (-16.11%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `67.20% <100.00%> (-15.36%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1537 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599265633
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.45%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 47.45% -19.56%
+ Complexity 28461 16645 -11816
=============================================
Files 2520 2046 -474
Lines 140046 115731 -24315
Branches 17197 14900 -2297
=============================================
- Hits 93850 54921 -38929
- Misses 38529 54988 +16459
+ Partials 7667 5822 -1845
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.73% <66.00%> (-17.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <64.00%> (-12.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.59% <100.00%> (-6.11%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.93% <100.00%> (-16.11%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `67.20% <100.00%> (-15.36%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1528 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599401173
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29134 +673
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96310 +2460
+ Misses 38529 35962 -2567
- Partials 7667 7760 +93
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.29% <84.00%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <72.00%> (-0.11%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [134 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #17781:
URL: https://github.com/apache/hudi/pull/17781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943632236
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.33333%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.06%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 57.28% 40.06% -17.23%
+ Complexity 18532 12402 -6130
=============================================
Files 1944 1927 -17
Lines 106132 103698 -2434
Branches 13118 12527 -591
=============================================
- Hits 60797 41542 -19255
- Misses 39612 57200 +17588
+ Partials 5723 4956 -767
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <64.00%> (-12.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.27% <100.00%> (-22.84%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-25.55%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `60.58% <100.00%> (-20.76%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `49.85% <100.00%> (-30.57%)` | :arrow_down: |
| [...hadoop/HoodieFileGroupReaderBasedRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieFileGroupReaderBasedRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUZpbGVHcm91cFJlYWRlckJhc2VkUmVjb3JkUmVhZGVyLmphdmE=) | `75.38% <100.00%> (-8.21%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [859 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943625297
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.33333%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.50%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|1|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 57.28% 40.50% -16.78%
+ Complexity 18532 12237 -6295
=============================================
Files 1944 1910 -34
Lines 106132 101363 -4769
Branches 13118 12028 -1090
=============================================
- Hits 60797 41057 -19740
- Misses 39612 55486 +15874
+ Partials 5723 4820 -903
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.62% <64.00%> (-11.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.27% <100.00%> (-22.84%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-25.55%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `60.58% <100.00%> (-20.76%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `49.85% <100.00%> (-30.57%)` | :arrow_down: |
| [...hadoop/HoodieFileGroupReaderBasedRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieFileGroupReaderBasedRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUZpbGVHcm91cFJlYWRlckJhc2VkUmVjb3JkUmVhZGVyLmphdmE=) | `75.38% <100.00%> (-8.21%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [869 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943705169
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.00000%` with `21 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.85%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 48.85% -8.43%
+ Complexity 18532 15771 -2761
============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
============================================
- Hits 60797 51842 -8955
- Misses 39612 48951 +9339
+ Partials 5723 5321 -402
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.18% <82.66%> (-4.25%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <64.00%> (-12.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.90% <100.00%> (-3.21%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `89.61% <100.00%> (-0.44%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `70.69% <100.00%> (-10.65%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `87.75% <100.00%> (-0.53%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [521 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308474859
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.18%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.18% +10.90%
- Complexity 18532 30487 +11955
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 102842 +42045
- Misses 39612 40037 +425
- Partials 5723 7947 +2224
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.81% <83.33%> (+0.38%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.44% <72.00%> (+0.93%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `85.46% <100.00%> (+4.12%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1393 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943455401
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
}, {
"hash" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d007ce8b130c35eabaad6d953bd0c0cac4b093a3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822)
* b396fdf3adeed2cb6672ec46fee918b8433e413a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943666159
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.50%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|3|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 57.28% 43.50% -13.79%
+ Complexity 18532 13828 -4704
=============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
=============================================
- Hits 60797 46163 -14634
- Misses 39612 54656 +15044
+ Partials 5723 5295 -428
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.19% <66.00%> (-14.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.13% <64.00%> (-12.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.18% <100.00%> (-3.93%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-12.99%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `70.69% <100.00%> (-10.65%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `65.78% <100.00%> (-14.64%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [768 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308393710
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.44%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 67.44% +10.16%
- Complexity 18532 30253 +11721
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 101726 +40929
- Misses 39612 41248 +1636
- Partials 5723 7852 +2129
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.81% <83.33%> (-1.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.31% <72.00%> (+0.80%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `85.46% <100.00%> (+4.12%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1390 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308515828
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.79% <84.00%> (+3.36%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308523331
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.79% <84.00%> (+3.36%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599190760
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.51%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 48.51% -18.50%
+ Complexity 28461 16295 -12166
=============================================
Files 2520 1994 -526
Lines 140046 110488 -29558
Branches 17197 13776 -3421
=============================================
- Hits 93850 53603 -40247
- Misses 38529 51321 +12792
+ Partials 7667 5564 -2103
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.74% <66.00%> (-16.60%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <64.00%> (-12.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.59% <100.00%> (-6.11%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.93% <100.00%> (-16.11%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `67.20% <100.00%> (-15.36%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599257853
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.43%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 47.43% -19.58%
+ Complexity 28461 16639 -11822
=============================================
Files 2520 2046 -474
Lines 140046 115731 -24315
Branches 17197 14900 -2297
=============================================
- Hits 93850 54902 -38948
- Misses 38529 55006 +16477
+ Partials 7667 5823 -1844
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.72% <66.00%> (-17.62%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <64.00%> (-12.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.59% <100.00%> (-6.11%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.93% <100.00%> (-16.11%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `67.20% <100.00%> (-15.36%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1528 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599285120
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `85.53459%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.64%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 67.01% 65.64% -1.38%
+ Complexity 28461 27752 -709
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
- Hits 93850 91921 -1929
- Misses 38529 40362 +1833
- Partials 7667 7749 +82
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.73% <66.00%> (-17.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <72.00%> (+0.09%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.30% <100.00%> (-1.40%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.53% <100.00%> (-7.51%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `86.39% <100.00%> (-1.89%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [463 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599396588
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.73%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.73% +1.71%
- Complexity 28461 29109 +648
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96247 +2397
+ Misses 38529 36034 -2495
- Partials 7667 7751 +84
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.29% <84.00%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <72.00%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [146 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4343973626
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 200 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.84% <84.00%> (+3.42%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308351469
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.09%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.09% +0.81%
- Complexity 18532 22458 +3926
============================================
Files 1944 2020 +76
Lines 106132 127398 +21266
Branches 13118 17683 +4565
============================================
+ Hits 60797 74015 +13218
- Misses 39612 46879 +7267
- Partials 5723 6504 +781
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.48% <83.33%> (-0.94%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.56% <72.00%> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [489 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308338426
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.32%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.32% +1.03%
- Complexity 18532 22395 +3863
============================================
Files 1944 2019 +75
Lines 106132 126587 +20455
Branches 13118 17438 +4320
============================================
+ Hits 60797 73829 +13032
- Misses 39612 46285 +6673
- Partials 5723 6473 +750
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.48% <83.33%> (-0.94%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <72.00%> (-0.82%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [485 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308519880
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.79% <84.00%> (+3.36%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4309832310
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 175 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.84% <84.00%> (+3.42%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943811630
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.33333%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.27%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 57.27% -0.02%
- Complexity 18532 18533 +1
============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
============================================
- Hits 60797 60775 -22
- Misses 39612 39619 +7
+ Partials 5723 5720 -3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.42% <83.33%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <72.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.18% <100.00%> (+0.07%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.37% <100.00%> (+0.03%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943801619
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.33333%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.27%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 57.27% -0.02%
- Complexity 18532 18533 +1
============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
============================================
- Hits 60797 60773 -24
- Misses 39612 39621 +9
+ Partials 5723 5720 -3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.35% <83.33%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <72.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.18% <100.00%> (+0.07%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.37% <100.00%> (+0.03%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943729410
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.66667%` with `20 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.52%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 55.52% -1.77%
+ Complexity 18532 17910 -622
============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
============================================
- Hits 60797 58915 -1882
- Misses 39612 41409 +1797
- Partials 5723 5790 +67
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.51% <82.66%> (-3.92%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <72.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.81% <100.00%> (-0.30%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `74.76% <100.00%> (-6.59%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [226 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599513967
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.80%
- Complexity 28461 29163 +702
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96375 +2525
+ Misses 38529 35885 -2644
- Partials 7667 7772 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.35% <84.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <72.00%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [127 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599172126
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.33333%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.64%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 39.64% -27.37%
+ Complexity 28461 12656 -15805
=============================================
Files 2520 1977 -543
Lines 140046 107946 -32100
Branches 17197 13186 -4011
=============================================
- Hits 93850 42797 -51053
- Misses 38529 59953 +21424
+ Partials 7667 5196 -2471
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <64.00%> (-12.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `67.02% <100.00%> (-25.68%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `64.50% <100.00%> (-26.41%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.18% <100.00%> (-25.86%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `53.38% <100.00%> (-29.18%)` | :arrow_down: |
| [...hadoop/HoodieFileGroupReaderBasedRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieFileGroupReaderBasedRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUZpbGVHcm91cFJlYWRlckJhc2VkUmVjb3JkUmVhZGVyLmphdmE=) | `75.38% <100.00%> (-8.21%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1841 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3874686544
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d007ce8b130c35eabaad6d953bd0c0cac4b093a3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous closed pull request #17781: refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters
URL: https://github.com/apache/hudi/pull/17781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308388444
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.04%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 67.04% +9.76%
- Complexity 18532 30054 +11522
============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
============================================
+ Hits 60797 101127 +40330
- Misses 39612 41878 +2266
- Partials 5723 7821 +2098
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.81% <83.33%> (-1.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.18% <72.00%> (-1.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `84.17% <100.00%> (+2.83%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1389 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943508846
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.38462%` with `45 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.36%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|0|
>|spark-java-tests|9|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 57.28% 45.36% -11.92%
+ Complexity 18532 8369 -10163
=============================================
Files 1944 1177 -767
Lines 106132 60215 -45917
Branches 13118 6422 -6696
=============================================
- Hits 60797 27317 -33480
+ Misses 39612 29924 -9688
+ Partials 5723 2974 -2749
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `49.35% <100.00%> (-40.70%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `53.49% <100.00%> (-27.85%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `88.23% <100.00%> (-4.63%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `48.37% <100.00%> (-32.04%)` | :arrow_down: |
| [...hadoop/HoodieFileGroupReaderBasedRecordReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-hadoop-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fhadoop%2FHoodieFileGroupReaderBasedRecordReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZUZpbGVHcm91cFJlYWRlckJhc2VkUmVjb3JkUmVhZGVyLmphdmE=) | `75.38% <100.00%> (-8.21%)` | :arrow_down: |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | `74.19% <50.00%> (-9.68%)` | :arrow_down: |
| ... and [6 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1370 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943728419
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.66667%` with `20 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.52%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 57.28% 55.52% -1.77%
+ Complexity 18532 17910 -622
============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
============================================
- Hits 60797 58915 -1882
- Misses 39612 41409 +1797
- Partials 5723 5790 +67
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.51% <82.66%> (-3.92%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <72.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.81% <100.00%> (-0.30%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `74.76% <100.00%> (-6.59%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [226 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943651709
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.29%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 57.28% 43.29% -13.99%
+ Complexity 18532 13725 -4807
=============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
=============================================
- Hits 60797 45942 -14855
- Misses 39612 54925 +15313
+ Partials 5723 5247 -476
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.19% <66.00%> (-14.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <64.00%> (-12.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.18% <100.00%> (-3.93%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-12.99%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `70.69% <100.00%> (-10.65%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `65.78% <100.00%> (-14.64%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [772 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599010332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
}, {
"hash" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209",
"triggerID" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"triggerType" : "PUSH"
}, {
"hash" : "5517d5a617927e8fb2afba4619cf814813fe1dca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5517d5a617927e8fb2afba4619cf814813fe1dca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b396fdf3adeed2cb6672ec46fee918b8433e413a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209)
* 5517d5a617927e8fb2afba4619cf814813fe1dca UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599242528
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.18%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|3|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 48.18% -18.84%
+ Complexity 28461 16554 -11907
=============================================
Files 2520 2024 -496
Lines 140046 113201 -26845
Branches 17197 14352 -2845
=============================================
- Hits 93850 54542 -39308
- Misses 38529 52924 +14395
+ Partials 7667 5735 -1932
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.11% <66.00%> (-17.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <64.00%> (-12.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.59% <100.00%> (-6.11%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.93% <100.00%> (-16.11%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `67.20% <100.00%> (-15.36%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1537 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599389660
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.64% +1.63%
- Complexity 28461 29064 +603
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96125 +2275
+ Misses 38529 36163 -2366
- Partials 7667 7744 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.98% <84.00%> (-0.36%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <72.00%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [157 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599293993
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `85.53459%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.85%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 67.01% 65.85% -1.16%
+ Complexity 28461 27897 -564
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
- Hits 93850 92222 -1628
- Misses 38529 39955 +1426
- Partials 7667 7855 +188
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.73% <66.00%> (-17.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <72.00%> (-0.36%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.30% <100.00%> (-1.40%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.53% <100.00%> (-7.51%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `86.39% <100.00%> (-1.89%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [461 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599455331
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.80%
- Complexity 28461 29163 +702
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96373 +2523
+ Misses 38529 35887 -2642
- Partials 7667 7772 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <84.00%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <72.00%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943648665
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.88%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 57.28% 43.88% -13.40%
+ Complexity 18532 13637 -4895
=============================================
Files 1944 1927 -17
Lines 106132 103698 -2434
Branches 13118 12527 -591
=============================================
- Hits 60797 45510 -15287
- Misses 39612 52979 +13367
+ Partials 5723 5209 -514
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.02% <66.00%> (-13.41%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <64.00%> (-12.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.18% <100.00%> (-3.93%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-12.99%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `70.69% <100.00%> (-10.65%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `65.78% <100.00%> (-14.64%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [789 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3708408895
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e40651d03ea05acd228032af487a58ba24d2e06 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787)
* 7afbdd6738ffb301e0cb760e39f578d4a360074b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308491513
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.42%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.42% +11.13%
- Complexity 18532 30635 +12103
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103198 +42401
+ Misses 39612 39576 -36
- Partials 5723 8052 +2329
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.87% <84.00%> (+2.45%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `85.46% <100.00%> (+4.12%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308362620
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.34%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.34% +1.06%
- Complexity 18532 22592 +4060
============================================
Files 1944 2020 +76
Lines 106132 127403 +21271
Branches 13118 17687 +4569
============================================
+ Hits 60797 74338 +13541
- Misses 39612 46487 +6875
- Partials 5723 6578 +855
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.25% <83.33%> (-1.17%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.18% <72.00%> (-1.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #17781:
URL: https://github.com/apache/hudi/pull/17781#discussion_r3338870235
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -81,25 +85,113 @@ public final class HoodieFileGroupReader<T> implements Closeable {
private HoodieFileGroupRecordBuffer<T> recordBuffer;
private ClosableIterator<T> baseFileIterator;
private final Option<UnaryOperator<T>> outputConverter;
+ @Getter
private final HoodieReadStats readStats;
// Callback to run custom logic on updates to the base files for the file group
private final Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback;
// The list of instant times read from the log blocks, this value is used by the log-compaction to allow optimized log-block scans
+ @Getter
private List<String> validBlockInstants = Collections.emptyList();
private BufferedRecordConverter<T> bufferedRecordConverter;
- private HoodieFileGroupReader(HoodieReaderContext<T> readerContext, HoodieStorage storage, String tablePath,
- String latestCommitTime, HoodieSchema dataSchema, HoodieSchema requestedSchema,
- Option<InternalSchema> internalSchemaOpt, HoodieTableMetaClient hoodieTableMetaClient, TypedProperties props,
- ReaderParameters readerParameters, InputSplit inputSplit, Option<BaseFileUpdateCallback<T>> updateCallback,
- FileGroupRecordBufferLoader<T> recordBufferLoader) {
+ @Builder(setterPrefix = "with")
+ private HoodieFileGroupReader(
+ HoodieReaderContext<T> readerContext,
+ String latestCommitTime,
+ HoodieSchema dataSchema,
+ HoodieSchema requestedSchema,
+ Option<InternalSchema> internalSchemaOpt,
+ HoodieTableMetaClient hoodieTableMetaClient,
+ TypedProperties props,
+ Option<HoodieBaseFile> baseFileOption,
+ Stream<HoodieLogFile> logFiles,
+ String partitionPath,
+ Long start,
+ Long length,
+ Iterator<? extends HoodieRecord> recordIterator,
+ Boolean shouldUseRecordPosition,
+ Boolean allowInflightInstants,
+ Boolean emitDelete,
+ Boolean sortOutput,
+ Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback,
+ FileGroupRecordBufferLoader<T> recordBufferLoader) {
+
+ // Validations
+ ValidationUtils.checkArgument(readerContext != null, "Reader context is required");
+ ValidationUtils.checkArgument(hoodieTableMetaClient != null, "Hoodie table meta client is required");
+ ValidationUtils.checkArgument(latestCommitTime != null, "Latest commit time is required");
+ ValidationUtils.checkArgument(dataSchema != null, "Data schema is required");
+ ValidationUtils.checkArgument(requestedSchema != null, "Requested schema is required");
+ ValidationUtils.checkArgument(props != null, "Props is required");
+ ValidationUtils.checkArgument(partitionPath != null, "Partition path is required");
+
+ // Handle defaults
Review Comment:
Yeap, it's possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #17781:
URL: https://github.com/apache/hudi/pull/17781#discussion_r3338888220
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -81,25 +85,113 @@ public final class HoodieFileGroupReader<T> implements Closeable {
private HoodieFileGroupRecordBuffer<T> recordBuffer;
private ClosableIterator<T> baseFileIterator;
private final Option<UnaryOperator<T>> outputConverter;
+ @Getter
private final HoodieReadStats readStats;
// Callback to run custom logic on updates to the base files for the file group
private final Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback;
// The list of instant times read from the log blocks, this value is used by the log-compaction to allow optimized log-block scans
+ @Getter
private List<String> validBlockInstants = Collections.emptyList();
private BufferedRecordConverter<T> bufferedRecordConverter;
- private HoodieFileGroupReader(HoodieReaderContext<T> readerContext, HoodieStorage storage, String tablePath,
- String latestCommitTime, HoodieSchema dataSchema, HoodieSchema requestedSchema,
- Option<InternalSchema> internalSchemaOpt, HoodieTableMetaClient hoodieTableMetaClient, TypedProperties props,
- ReaderParameters readerParameters, InputSplit inputSplit, Option<BaseFileUpdateCallback<T>> updateCallback,
- FileGroupRecordBufferLoader<T> recordBufferLoader) {
+ @Builder(setterPrefix = "with")
+ private HoodieFileGroupReader(
+ HoodieReaderContext<T> readerContext,
+ String latestCommitTime,
+ HoodieSchema dataSchema,
+ HoodieSchema requestedSchema,
+ Option<InternalSchema> internalSchemaOpt,
+ HoodieTableMetaClient hoodieTableMetaClient,
+ TypedProperties props,
+ Option<HoodieBaseFile> baseFileOption,
+ Stream<HoodieLogFile> logFiles,
+ String partitionPath,
+ Long start,
+ Long length,
+ Iterator<? extends HoodieRecord> recordIterator,
+ Boolean shouldUseRecordPosition,
+ Boolean allowInflightInstants,
+ Boolean emitDelete,
+ Boolean sortOutput,
+ Option<BaseFileUpdateCallback<T>> fileGroupUpdateCallback,
+ FileGroupRecordBufferLoader<T> recordBufferLoader) {
+
+ // Validations
+ ValidationUtils.checkArgument(readerContext != null, "Reader context is required");
+ ValidationUtils.checkArgument(hoodieTableMetaClient != null, "Hoodie table meta client is required");
+ ValidationUtils.checkArgument(latestCommitTime != null, "Latest commit time is required");
+ ValidationUtils.checkArgument(dataSchema != null, "Data schema is required");
+ ValidationUtils.checkArgument(requestedSchema != null, "Requested schema is required");
+ ValidationUtils.checkArgument(props != null, "Props is required");
+ ValidationUtils.checkArgument(partitionPath != null, "Partition path is required");
+
+ // Handle defaults
Review Comment:
Possible, but it will blow up this refactoring.
We will first need to add `@Builder` to the class. Even so, most of these parameters aren't stored 1:1 as fields. They're transformed in the constructor body:
1. `start` / `length` is folded into `InputSplit`
2. `internalSchemaOpt` is passed to the schema handler
3. `shouldUseRecordPosition` / `emitDelete` / `sortOutput` / `allowInflightInstants` are folded into `ReaderParameters`
So there are no `start`/`length`/`shouldUseRecordPosition` fields to hang a `@Builder.Default` on.
To use it you will have to restructure into class-level `@Builder` with real defaulted fields and move all the validation/derivation logic out of the constructor (e.g. into the composite builders or a factory), all these will blow up the refactoring as a much bigger change than the null checks buy back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599231243
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.60%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|2|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 48.60% -18.42%
+ Complexity 28461 16295 -12166
=============================================
Files 2520 1994 -526
Lines 140046 110493 -29553
Branches 17197 13782 -3415
=============================================
- Hits 93850 53703 -40147
- Misses 38529 51242 +12713
+ Partials 7667 5548 -2119
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.74% <66.00%> (-16.60%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <64.00%> (-12.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.59% <100.00%> (-6.11%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.93% <100.00%> (-16.11%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `67.20% <100.00%> (-15.36%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1553 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599283984
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `85.53459%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.64%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 67.01% 65.64% -1.38%
+ Complexity 28461 27752 -709
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
- Hits 93850 91921 -1929
- Misses 38529 40362 +1833
- Partials 7667 7749 +82
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.73% <66.00%> (-17.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <72.00%> (+0.09%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.30% <100.00%> (-1.40%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.53% <100.00%> (-7.51%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `86.39% <100.00%> (-1.89%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [463 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599361399
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `85.53459%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.89%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 67.01% 65.89% -1.12%
+ Complexity 28461 27897 -564
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
- Hits 93850 92276 -1574
- Misses 38529 39938 +1409
- Partials 7667 7818 +151
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.73% <66.00%> (-17.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <72.00%> (-0.30%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `91.30% <100.00%> (-1.40%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `80.08% <100.00%> (-10.83%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.53% <100.00%> (-7.51%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `86.39% <100.00%> (-1.89%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [443 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599486052
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.16352%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.80%
- Complexity 28461 29163 +702
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 96375 +2525
+ Misses 38529 35885 -2644
- Partials 7667 7772 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <84.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <72.00%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.75% <100.00%> (+0.05%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.68% <100.00%> (+0.65%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [127 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943465173
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
}, {
"hash" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209",
"triggerID" : "b396fdf3adeed2cb6672ec46fee918b8433e413a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d007ce8b130c35eabaad6d953bd0c0cac4b093a3 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11822)
* b396fdf3adeed2cb6672ec46fee918b8433e413a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12209)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3943651183
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.29%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8c5f832) and HEAD (b396fdf). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (8c5f832) | HEAD (b396fdf) |
>|------|------|------|
>|spark-scala-tests|6|2|
>|spark-java-tests|9|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 57.28% 43.29% -13.99%
+ Complexity 18532 13725 -4807
=============================================
Files 1944 1944
Lines 106132 106114 -18
Branches 13118 13126 +8
=============================================
- Hits 60797 45942 -14855
- Misses 39612 54925 +15313
+ Partials 5723 5247 -476
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.36% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.19% <66.00%> (-14.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <64.00%> (-12.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `86.18% <100.00%> (-3.93%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-12.99%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `70.69% <100.00%> (-10.65%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `65.78% <100.00%> (-14.64%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [772 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308499556
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.63%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.63% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103526 +42729
+ Misses 39612 39260 -352
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.79% <84.00%> (+3.36%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308391150
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.44%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 67.44% +10.16%
- Complexity 18532 30253 +11721
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 101726 +40929
- Misses 39612 41248 +1636
- Partials 5723 7852 +2129
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.81% <83.33%> (-1.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.31% <72.00%> (+0.80%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `85.46% <100.00%> (+4.12%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1390 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308372600
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.38%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.38% +1.10%
- Complexity 18532 22613 +4081
============================================
Files 1944 2020 +76
Lines 106132 127403 +21271
Branches 13118 17687 +4569
============================================
+ Hits 60797 74387 +13590
- Misses 39612 46434 +6822
- Partials 5723 6582 +859
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.81% <83.33%> (-1.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.18% <72.00%> (-1.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [496 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308324108
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.54%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 57.28% 58.54% +1.25%
- Complexity 18532 22334 +3802
============================================
Files 1944 2019 +75
Lines 106132 125797 +19665
Branches 13118 17185 +4067
============================================
+ Hits 60797 73643 +12846
- Misses 39612 45702 +6090
- Partials 5723 6452 +729
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.48% <83.33%> (-0.94%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <72.00%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `90.90% <100.00%> (+0.79%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `79.36% <100.00%> (-9.53%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.04% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `81.21% <100.00%> (-0.13%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [481 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4308526686
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.05031%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`8c5f832`](https://app.codecov.io/gh/apache/hudi/commit/8c5f83237c11f6b67f99e56fb06881312e39a625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b396fdf`](https://app.codecov.io/gh/apache/hudi/commit/b396fdf3adeed2cb6672ec46fee918b8433e413a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 174 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 81.63% | [1 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
+ Coverage 57.28% 68.64% +11.35%
- Complexity 18532 30739 +12207
=============================================
Files 1944 2481 +537
Lines 106132 150826 +44694
Branches 13118 19882 +6764
=============================================
+ Hits 60797 103527 +42730
+ Misses 39612 39259 -353
- Partials 5723 8040 +2317
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.44% <54.30%> (?)` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.81% <65.38%> (+1.40%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <53.54%> (?)` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.82% <84.00%> (+3.39%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.72% <72.00%> (+1.21%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.98% <57.74%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.72% <100.00%> (+2.61%)` | :arrow_up: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `93.65% <100.00%> (+4.76%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (+0.86%)` | :arrow_up: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `88.85% <100.00%> (+7.50%)` | :arrow_up: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3866118500
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
}, {
"hash" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d007ce8b130c35eabaad6d953bd0c0cac4b093a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7afbdd6738ffb301e0cb760e39f578d4a360074b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789)
* d007ce8b130c35eabaad6d953bd0c0cac4b093a3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3708334080
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e40651d03ea05acd228032af487a58ba24d2e06 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787)
* 7afbdd6738ffb301e0cb760e39f578d4a360074b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-3708374140
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787",
"triggerID" : "2e40651d03ea05acd228032af487a58ba24d2e06",
"triggerType" : "PUSH"
}, {
"hash" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789",
"triggerID" : "7afbdd6738ffb301e0cb760e39f578d4a360074b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e40651d03ea05acd228032af487a58ba24d2e06 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10787)
* 7afbdd6738ffb301e0cb760e39f578d4a360074b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10789)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599271418
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `84.90566%` with `24 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.37%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
- Coverage 67.01% 58.37% -8.65%
+ Complexity 28461 24679 -3782
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
- Hits 93850 81738 -12112
- Misses 38529 51255 +12726
+ Partials 7667 7039 -628
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.73% <66.00%> (-17.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <64.00%> (-12.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `89.49% <100.00%> (-3.21%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `79.65% <100.00%> (-11.26%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `71.09% <100.00%> (-11.94%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [594 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599184227
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.33333%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.63%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 77.55% | [1 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...d/buffer/StreamingFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FStreamingFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1N0cmVhbWluZ0ZpbGVHcm91cFJlY29yZEJ1ZmZlckxvYWRlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (5517d5a). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (5517d5a) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
=============================================
- Coverage 67.01% 42.63% -24.38%
+ Complexity 28461 13974 -14487
=============================================
Files 2520 1994 -526
Lines 140046 110488 -29558
Branches 17197 13776 -3421
=============================================
- Hits 93850 47108 -46742
- Misses 38529 57858 +19329
+ Partials 7667 5522 -2145
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.74% <66.00%> (-16.60%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <64.00%> (-12.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `85.86% <100.00%> (-6.84%)` | :arrow_down: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `77.05% <100.00%> (-13.86%)` | :arrow_down: |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.57% <100.00%> (-16.46%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `85.71% <100.00%> (-2.57%)` | :arrow_down: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `92.15% <100.00%> (-0.71%)` | :arrow_down: |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ad/buffer/ReusableFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FReusableFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL1JldXNhYmxlRmlsZUdyb3VwUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `94.11% <100.00%> (ø)` | |
| [...pache/hudi/metadata/HoodieBackedTableMetadata.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllQmFja2VkVGFibGVNZXRhZGF0YS5qYXZh) | `66.66% <100.00%> (-15.90%)` | :arrow_down: |
| ... and [11 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1765 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Add Lombok Builders to HoodieFileGroupReader, InputSplit, ReaderParameters [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17781:
URL: https://github.com/apache/hudi/pull/17781#issuecomment-4599365265
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `85.53459%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.74%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5517d5a`](https://app.codecov.io/gh/apache/hudi/commit/5517d5a617927e8fb2afba4619cf814813fe1dca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/common/table/read/HoodieFileGroupReader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FHoodieFileGroupReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSG9vZGllRmlsZUdyb3VwUmVhZGVyLmphdmE=) | 79.59% | [1 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/hudi/cli/commands/HoodieLogFileCommand.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FHoodieLogFileCommand.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL0hvb2RpZUxvZ0ZpbGVDb21tYW5kLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/hudi/metadata/HoodieTableMetadataUtil.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieTableMetadataUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0YWRhdGEvSG9vZGllVGFibGVNZXRhZGF0YVV0aWwuamF2YQ==) | 20.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/common/table/read/InputSplit.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FInputSplit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvSW5wdXRTcGxpdC5qYXZh) | 76.92% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...scala/org/apache/hudi/HoodieMergeOnReadRDDV2.scala](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieMergeOnReadRDDV2.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVNZXJnZU9uUmVhZFJERFYyLnNjYWxh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17781 +/- ##
============================================
+ Coverage 67.01% 67.74% +0.73%
- Complexity 28461 28668 +207
============================================
Files 2520 2520
Lines 140046 140032 -14
Branches 17197 17205 +8
============================================
+ Hits 93850 94865 +1015
+ Misses 38529 37402 -1127
- Partials 7667 7765 +98
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <52.83%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <65.38%> (-0.05%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <50.38%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <83.33%> (-4.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <72.00%> (-0.30%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/17781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.39% <61.33%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/17781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/hudi/index/HoodieIndexUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Findex%2FHoodieIndexUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2luZGV4L0hvb2RpZUluZGV4VXRpbHMuamF2YQ==) | `92.02% <100.00%> (-0.68%)` | :arrow_down: |
| [...ache/hudi/io/FileGroupReaderBasedAppendHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedAppendHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkQXBwZW5kSGFuZGxlLmphdmE=) | `90.90% <100.00%> (+2.02%)` | :arrow_up: |
| [...pache/hudi/io/FileGroupReaderBasedMergeHandle.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fio%2FFileGroupReaderBasedMergeHandle.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2lvL0ZpbGVHcm91cFJlYWRlckJhc2VkTWVyZ2VIYW5kbGUuamF2YQ==) | `90.90% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.53% <100.00%> (-7.51%)` | :arrow_down: |
| [.../metadata/SecondaryIndexRecordGenerationUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FSecondaryIndexRecordGenerationUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL1NlY29uZGFyeUluZGV4UmVjb3JkR2VuZXJhdGlvblV0aWxzLmphdmE=) | `88.43% <100.00%> (+0.15%)` | :arrow_up: |
| [.../cluster/strategy/ClusteringExecutionStrategy.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcluster%2Fstrategy%2FClusteringExecutionStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbHVzdGVyL3N0cmF0ZWd5L0NsdXN0ZXJpbmdFeGVjdXRpb25TdHJhdGVneS5qYXZh) | `94.11% <100.00%> (+1.26%)` | :arrow_up: |
| [...he/hudi/client/utils/SparkMetadataWriterUtils.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Futils%2FSparkMetadataWriterUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL1NwYXJrTWV0YWRhdGFXcml0ZXJVdGlscy5qYXZh) | `85.00% <100.00%> (ø)` | |
| [...pache/hudi/common/table/read/ReaderParameters.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2FReaderParameters.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvUmVhZGVyUGFyYW1ldGVycy5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ead/buffer/DefaultFileGroupRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FDefaultFileGroupRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0RlZmF1bHRGaWxlR3JvdXBSZWNvcmRCdWZmZXJMb2FkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ble/read/buffer/LogScanningRecordBufferLoader.java](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Fread%2Fbuffer%2FLogScanningRecordBufferLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3JlYWQvYnVmZmVyL0xvZ1NjYW5uaW5nUmVjb3JkQnVmZmVyTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/17781?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [286 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/17781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org