[GitHub] [beam] lukecwik commented on a change in pull request #11103: [BEAM-9494] Reifying outputs from BQ file writing

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #11103: [BEAM-9494] Reifying outputs from BQ file writing
URL: https://github.com/apache/beam/pull/11103#discussion_r391837106
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery_file_loads.py
 ##########
 @@ -739,9 +739,12 @@ def _write_files(self, destination_data_kv_pc, file_prefix_pcv):
             file_prefix_pcv,
             *self.schema_side_inputs))
 
+    # We flatten both PCollection paths, and reify. We do this due to some
+    # trickiness with coder-setting on Flatten-GBK boundaries.
     all_destination_file_pairs_pc = (
         (destination_files_kv_pc, more_destination_files_kv_pc)
 
 Review comment:
   ```suggestion
       # TODO(BEAM-9494): Remove the identity transform. We flatten both PCollection paths
       # and use an identity function to work around a flatten optimization issue where the wrong
       # coder is being used.
       all_destination_file_pairs_pc = (
           (destination_files_kv_pc, more_destination_files_kv_pc)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services