You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/09/10 14:02:30 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9592: webapp: migrate from Spring Web to Armeria

wu-sheng commented on code in PR #9592:
URL: https://github.com/apache/skywalking/pull/9592#discussion_r967657284


##########
docs/en/setup/backend/ui-setup.md:
##########
@@ -46,4 +31,4 @@ We could set up environment variables to configure this image.
 
 ### SW_OAP_ADDRESS
 
-The address of your OAP server. The default value is `http://127.0.0.1:12800`.
\ No newline at end of file
+The address of your OAP server. The default value is `127.0.0.1:12800`.

Review Comment:
   Some ppl would be surprised we don't need `http://` again. Because we just changed from this to `http://xx` when move from zuul to Spring Gateway last year?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org